Support HTTP.jl 2 - #362
Open
asinghvi17 wants to merge 1 commit into
Open
asinghvi17 wants to merge 1 commit into
asinghvi17 wants to merge 1 commit into
Conversation
HTTP.jl 2.0 removes String(::Message), rejects unknown request keywords, and wraps server request bodies in HTTP.BytesBody. Bump julia compat to 1.10, the floor HTTP.jl 2.0 requires. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
DilumAluthge
approved these changes
Sep 12, 2026
Member
|
CI is sad? |
Author
|
The CI issues are all coming from Reseau.jl it seems, cc @quinnj |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the HTTP.jl compat bound to
2and migrates the call sites that 2.0 changed.juliacompat moves to1.10, the floor HTTP.jl 2.0 requires.Verified locally on Julia 1.13: 372 passing with HTTP 2.6.7, identical to the HTTP 1.11 baseline on
master.Changes
Codecov.submit_generic,Codecov.upload_to_s3,Coveralls.post_requestString(msg)→string(msg)Base.String(::Message).stringyields the same status-line/headers/body dump these@debugstatements already logged.Codecov.upload_to_s3header=keywordMethodErroron unrecognized request keywords (details below).test/runtests.jlJSON.parse(request.body)→JSON.parse(String(request.body))HTTP.BytesBodyrather than a byte vector.Untouched by the migration:
HTTP.post/HTTP.putverb calls,HTTP.FormandHTTP.Multipartuploads, thequeryandstatus_exceptionkeywords,HTTP.serve!/HTTP.port/HTTP.header, andString(response.body). Each behaves the same under 2.0.On the dropped
header=keywordHTTP.puthas never recognizedheader— the keyword isheaders— so 1.x silently discarded the dict, and the S3 upload has always gone out withoutContent-Typeorx-amz-storage-class. HTTP.jl 2.0 rejects unknown keywords, which is what surfaced this.This PR keeps the existing wire behavior instead of renaming the keyword to
headers, because the target is an S3 presigned PUT: anx-amz-storage-classheader outside the presignedX-Amz-SignedHeadersset makes S3 reject the upload withSignatureDoesNotMatch. Sending those headers is a separate change that also needs the signing side to cover them — happy to split it out if you'd like them enabled.This path sits in
submit_generic, which is already deprecated in favor of the Codecov uploader binary.Notes for review
julia = "1.10"is required rather than cosmetic: HTTP.jl 2.0 declares `julia = "1.10.0 - 1"🤖 Generated with Claude Code