Skip to content

Bind ReducedComplexityModeling to 0.5 - #373

Merged
michakraus merged 2 commits into
mainfrom
compat/rcm-0.5
Oct 31, 2026
Merged

michakraus merged 2 commits into
mainfrom
compat/rcm-0.5

Conversation

@michakraus

Copy link
Copy Markdown
Member

Binds ReducedComplexityModeling = "0.5" (from "0.4.1") before 0.9.0, so that this package can share an environment with ReducedBasisMethods 0.4 and with VlasovMethods from its next release, which bind ReducedComplexityModeling 0.5. A GML on "0.4.1" cannot resolve beside them.

What changes

  • Project.toml: the one [compat] line.
  • CHANGELOG.md: the [Unreleased] sentence that named the bound now names "0.5" and why.

No source, test, docs or script file changes. ReducedComplexityModeling 0.5.0 changes no file of its src/data_loader/ or src/TrainingProblem.jl, which hold every name this package imports from it, and its own [compat] is unchanged. The one change to its export list is export Array, which this package never reaches: it imports by name only.

Evidence

  • A fresh resolve of the root and of the test environment picks ReducedComplexityModeling v0.5.0.
  • The full suite passes with ReducedComplexityModeling 0.5.0 on Julia 1.13.3 (1097 s) and 1.12.7 (1970 s): 10788 of 10788 each, 0 failures. The two Metal testsets were not run (no GPU in the test environment).

Pre-PR verification

julia-branch-verifier: clear, 0 unresolved. Its one nit, that the registered VlasovMethods 0.3.0 still binds ReducedComplexityModeling "0.1.1", is applied: the CHANGELOG sentence names VlasovMethods' next release.

Pre-existing, not caused by this branch: the Downgrade job's forcedeps floors fail on main and on this branch alike. ChainRulesCore 1.0.0 (GeometricOptimizers 0.9.2 needs ≥ 1.25.1), NeuralNetworkParameters 0.5.0 (GeometricOptimizers 0.9.2 needs 0.5.3–0.5.4), KernelAbstractions 0.9.0, NNlib 0.8.0 and Zygote 0.7.0 cannot be installed at their lower bounds. The ReducedComplexityModeling floor 0.5.0 resolves alone and with the other installable floors.

Not checked: type stability and allocations (no source line changes, and the dependency code this package calls is byte-identical); no docs build (no docs/ change).

🤖 Generated with Claude Code

michakraus and others added 2 commits October 31, 2026 17:28
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9d4f309c-c037-4a15-b3cc-105866504aec
Commits

Reviewing files that changed from the base of the PR and between 0ecba12 and 577399f.

Files selected for processing: 2
  • CHANGELOG.md
  • Project.toml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Summary

Summary by CodeRabbit

  • Compatibility
    • Updated the supported compatibility requirement for ReducedComplexityModeling to version 0.5. Environments using ReducedBasisMethods 0.4 or the upcoming VlasovMethods release will resolve this package with that version.

The ReducedComplexityModeling compatibility bound changes from 0.4.1 to 0.5. The changelog describes the resolution constraint for environments with ReducedBasisMethods 0.4 or the next VlasovMethods release.

Changes: Dependency Compatibility

Layer / File(s) Summary
Update compatibility bound
Project.toml, CHANGELOG.md
Project.toml sets the ReducedComplexityModeling compatibility requirement to 0.5. The changelog documents the same bound and its stated resolution constraint.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related PRs

Merge Risk: Minimal · up to 57739

The compatibility update is ready to merge with no identified correctness or availability risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: updating the ReducedComplexityModeling compatibility bound to 0.5.
Description check Passed The description accurately explains the compatibility change, changelog update, motivation, validation results, and known test limitations.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@michakraus
michakraus merged commit 848d7f2 into main Oct 31, 2026
12 of 15 checks passed
@michakraus
michakraus deleted the compat/rcm-0.5 branch October 31, 2026 17:43
@codecov

codecov Bot commented Oct 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.48%. Comparing base (0ecba12) to head (577399f).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #373   +/-   ##
=======================================
  Coverage   94.48%   94.48%           
=======================================
  Files          63       63           
  Lines        2738     2738           
=======================================
  Hits         2587     2587           
  Misses        151      151           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

1 participant