Skip to content

Fix the closure-box test after moving KernelAbstractions methods - #602

Merged
maleadt merged 1 commit into
mainfrom
tb/fix-closure-test-modules
Oct 28, 2026
Merged

maleadt merged 1 commit into
mainfrom
tb/fix-closure-test-modules

Conversation

@maleadt

@maleadt maleadt commented Oct 28, 2026

Copy link
Copy Markdown
Member

The nightly closure-box test still looks up KernelAbstractionsExt, which was removed when its methods moved into OpenCL. The lookup returns nothing, so Test.detect_closure_boxes throws a MethodError before checking the modules.

Remove that lookup and the now-unused import. The test continues to inspect OpenCL, SPIRVIntrinsics, and its three loaded extensions.

Validated the closure-box check on Julia 1.14.0-DEV.3743 with all three SPIRVIntrinsics extensions loaded.

@maleadt
maleadt merged commit 4828021 into main Oct 28, 2026
17 of 18 checks passed
@maleadt
maleadt deleted the tb/fix-closure-test-modules branch October 28, 2026 20:12
@codecov

codecov Bot commented Oct 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.71%. Comparing base (920fb3e) to head (b55fde7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #602      +/-   ##
==========================================
+ Coverage   90.57%   90.71%   +0.14%     
==========================================
  Files          18       18              
  Lines        1740     1799      +59     
==========================================
+ Hits         1576     1632      +56     
- Misses        164      167       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant