Repository navigation
Fix the closure-box test after moving KernelAbstractions methods - #602
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #602 +/- ##
==========================================
+ Coverage 90.57% 90.71% +0.14%
==========================================
Files 18 18
Lines 1740 1799 +59
==========================================
+ Hits 1576 1632 +56
- Misses 164 167 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly closure-box test still looks up
KernelAbstractionsExt, which was removed when its methods moved into OpenCL. The lookup returnsnothing, soTest.detect_closure_boxesthrows aMethodErrorbefore checking the modules.Remove that lookup and the now-unused import. The test continues to inspect OpenCL, SPIRVIntrinsics, and its three loaded extensions.
Validated the closure-box check on Julia 1.14.0-DEV.3743 with all three SPIRVIntrinsics extensions loaded.