Skip to content

Bind ReducedComplexityModeling to 0.5 - #61

Merged
michakraus merged 3 commits into
mainfrom
compat/rcm-0.5
Oct 30, 2026
Merged

michakraus merged 3 commits into
mainfrom
compat/rcm-0.5

Conversation

@michakraus

@michakraus michakraus commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Binds ReducedComplexityModeling to "0.5" (from "0.1.1"), now that RCM 0.5.0 is registered. This replaces the Dependabot PR #58, which widened the bound to "0.1.1, 0.3".

What changes

  • [compat] ReducedComplexityModeling = "0.5".
  • [compat] GeometricEquations = "0.21.5" (from "0.21") and HDF5 = "0.17" (from "0.16.15, 0.17"). RCM 0.5 requires GeometricEquations 0.21.5 and GeometricSolutions 0.6.6, and GeometricSolutions ≥ 0.6.6 bounds HDF5 to 0.17, so the old floors could not resolve.
  • No source file changes. An HDF5 round trip of a ReducedBasis now keeps the written order of parameters and paramspace (RCM ≥ 0.2 tracks creation order); RCM 0.1 returned alphabetical order. Files written by 0.3.0 still load.
  • The CHANGELOG entry targets 0.4.0: ReducedBasis takes an RCM ParameterSpace and uses RCM's h5save/h5load generics, so a caller moves across RCM's breaking releases 0.2–0.5. The release number is the author's call.

Evidence

  • Full suite passes with RCM 0.5.0 resolved (GeometricEquations 0.21.6, GeometricSolutions 0.6.8, HDF5 0.17.4), on Julia 1.13.
  • The new floors (RCM 0.5.0, GeometricEquations 0.21.5, HDF5 0.17.0, MultiIndexArrays 0.1.2, Makie 0.24.0) resolve together on Julia 1.12.7 and 1.13.3.

Pre-PR verification

Two passes of julia-branch-verifier. The first raised the GeometricEquations and HDF5 floors and found three defects in the CHANGELOG entry, all fixed. The second is clear (0 unresolved); its two text corrections to the entry (the round-trip consequences, "bounds HDF5") are applied in 78b2749.

Checked and clean: RCM 0.5's requirements match the General registry; Aqua test_piracies passes; project and lift infer concrete return types with RCM 0.5; test/ and docs/ carry no stale bound for the raised dependencies.

Pre-existing, not in this PR:

  • The advisory Downgrade job is red on main: Documenter 1.19.0 does not resolve with the DocStringExtensions 0.10.2 floor.
  • ParameterSpace reaches the module through an implicit using ReducedComplexityModeling (src/ReducedBasisMethods.jl:7).
  • The HDF5 round-trip test in test/reducedbasis.jl uses keys already in alphabetical order, so it cannot see the order behaviour.

Not checked: allocations (no executable source change); a file written by RCM 0.1.1 itself (the old layout was rebuilt with the 0.5 writer).

VlasovMethods follows once an RBM release that binds RCM 0.5 is registered (it binds both packages).

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • HDF5 round trips now preserve parameter order for newly saved reduced-basis data. Files saved with version 0.3.0 continue to load with parameters in alphabetical order.
  • Compatibility
    • Updated supported version requirements for ReducedComplexityModeling, GeometricEquations, and HDF5.

michakraus and others added 3 commits October 30, 2026 23:02
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Walkthrough

The project narrows or raises compatibility requirements for three dependencies. The Unreleased changelog documents those requirements and records HDF5 round-trip parameter-order behavior.

Changes: Package compatibility update

Layer / File(s) Summary
Compatibility requirements and release notes
Project.toml, CHANGELOG.md
Project.toml updates compatibility entries for GeometricEquations, HDF5, and ReducedComplexityModeling. The changelog records the requirements and HDF5 parameter-order behavior for saved and loaded ReducedBasis objects.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Possibly related PRs

Suggested labels: dependencies, julia

Merge Risk: Low · up to 78b27

The change is mergeable, but add regression coverage for non-alphabetical parameter ordering to protect the documented compatibility behavior.

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@michakraus
michakraus merged commit 70b16e3 into main Oct 30, 2026
10 of 12 checks passed
@michakraus
michakraus deleted the compat/rcm-0.5 branch October 30, 2026 22:28
@codecov

codecov Bot commented Oct 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.56%. Comparing base (b319caa) to head (78b2749).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files          10       10           
  Lines         320      320           
=======================================
  Hits          309      309           
  Misses         11       11           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant