Repository navigation
Bind ReducedComplexityModeling to 0.5 - #61
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. Walkthrough
Merge Risk:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
=======================================
Coverage 96.56% 96.56%
=======================================
Files 10 10
Lines 320 320
=======================================
Hits 309 309
Misses 11 11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Binds ReducedComplexityModeling to
"0.5"(from"0.1.1"), now that RCM 0.5.0 is registered. This replaces the Dependabot PR #58, which widened the bound to"0.1.1, 0.3".What changes
[compat] ReducedComplexityModeling = "0.5".[compat] GeometricEquations = "0.21.5"(from"0.21") andHDF5 = "0.17"(from"0.16.15, 0.17"). RCM 0.5 requires GeometricEquations 0.21.5 and GeometricSolutions 0.6.6, and GeometricSolutions ≥ 0.6.6 bounds HDF5 to 0.17, so the old floors could not resolve.ReducedBasisnow keeps the written order ofparametersandparamspace(RCM ≥ 0.2 tracks creation order); RCM 0.1 returned alphabetical order. Files written by 0.3.0 still load.ReducedBasistakes an RCMParameterSpaceand uses RCM'sh5save/h5loadgenerics, so a caller moves across RCM's breaking releases 0.2–0.5. The release number is the author's call.Evidence
Pre-PR verification
Two passes of
julia-branch-verifier. The first raised the GeometricEquations and HDF5 floors and found three defects in the CHANGELOG entry, all fixed. The second is clear (0 unresolved); its two text corrections to the entry (the round-trip consequences, "bounds HDF5") are applied in 78b2749.Checked and clean: RCM 0.5's requirements match the General registry; Aqua
test_piraciespasses;projectandliftinfer concrete return types with RCM 0.5;test/anddocs/carry no stale bound for the raised dependencies.Pre-existing, not in this PR:
main: Documenter 1.19.0 does not resolve with the DocStringExtensions 0.10.2 floor.ParameterSpacereaches the module through an implicitusing ReducedComplexityModeling(src/ReducedBasisMethods.jl:7).test/reducedbasis.jluses keys already in alphabetical order, so it cannot see the order behaviour.Not checked: allocations (no executable source change); a file written by RCM 0.1.1 itself (the old layout was rebuilt with the 0.5 writer).
VlasovMethods follows once an RBM release that binds RCM 0.5 is registered (it binds both packages).
🤖 Generated with Claude Code
Summary by CodeRabbit