Repository navigation
Guard the ReducedTensor allocation readings on coverage - #62
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
=======================================
Coverage 96.56% 96.56%
=======================================
Files 10 10
Lines 320 320
=======================================
Hits 309 309
Misses 11 11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
== 0allocation readings ofReducedTensorand their> 0control intest/reduced_tensor.jlnow sit behindBase.JLOptions().code_coverage == 0, with the same comment astest/algorithms/symplectic_deim.jl. Coverage instrumentation allocates on its own account, and every other== 0reading of the suite is already guarded this way. An allocation sweep of the reduced-basis packages found this testset to be the one exception.Tests and
CHANGELOG.mdonly ([Unreleased] — targeting 0.4.1); nothing insrc/changes, and no release is needed for it.Evidence
test/reduced_tensor.jlpasses 74/74 with coverage off (Julia 1.13.3), and 62/62 under--code-coverage=user: the 12 guarded readings (3 readings × 2 element types × 2 widths) are skipped.getindexandcopyto!read 0 B; the guard is preventive and does not hide a present failure.Pre-PR verification
test/projection.jlhas unguarded ceiling, size-difference and> 0checks). It now reads "as the other== 0readings of the suite are".== 0allocation reading undertest/is behind the coverage guard:test/algorithms/symplectic_deim.jl,test/reduced_equations.jl(three blocks) andtest/reduced_tensor.jl.CHANGELOG.md.src/: the branch does not change it.🤖 Generated with Claude Code
Summary by CodeRabbit