Add grpcio-tools#1552
Open
SohierDane wants to merge 1 commit into
Open
Conversation
Contributor
|
Can you add a simple smoke test under the tests forder for the grpcio-tools package for the method you are using to ensure we don't regress: docker-python/tests/test_pandas.py Lines 1 to 9 in 8cc47ea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a dependency on
grpcio-toolsso we can recompile proto stubs in real time for kaggle_evaluation. It's a small library (<3 MB) and for my purposes the exact version doesn't much matter so I'm hoping this isn't a controversial addition. We do have alternatives if this addition isn't feasible but they're much more invasive, most likely migrating from gRPC to HTTP.