Repository navigation
Conversation
OnMessage runs on a native WebRTC thread that stays attached to the JVM, so local references created there are only freed when they are deleted explicitly. Two leaked on every message: the RTCDataChannelBuffer handed to the observer (released from its JavaLocalRef instead of kept by it) and the direct ByteBuffer it wraps. A busy server keeps millions of them alive, growing the heap by roughly 100 MB an hour until it runs out. Keep both in a JavaLocalRef so they are deleted when they go out of scope. The observer only reads the buffer during the call, as the native memory behind it is freed when OnMessage returns anyway. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015jA6r9hShSX7PhQWhVa1g1
Port the leak fixes from devopvoid/webrtc-java@8b77ec8 (#283) that apply to this data-channel-only fork: - RTCPeerConnection.close() cleared the Java handle but never released the reference createPeerConnection() had handed to Java, so every closed connection leaked the native PeerConnection and what it owned. - RTCDataChannel.registerObserver() allocated a native observer and never kept it, so unregisterObserver() could not free it. Each one leaked along with the JNI global reference to the Java observer, which kept the whole closed Java channel reachable. The observer is now stored in an observerHandle field and freed when it is replaced, unregistered, or the channel is disposed. - The data channel observer drops a callback instead of crashing when its thread can no longer attach to the JVM, during shutdown. The ReplaceNativeObserver/ClearNativeObserver helpers come from the same upstream commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015jA6r9hShSX7PhQWhVa1g1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.