Skip to content

KC-1378: Implement Ownership check for "Commander Service Mode Config" record - #2273

Merged
sk-keeper merged 1 commit into
releasefrom
fix/service-mode-config-owner
Aug 7, 2026
Merged

KC-1378: Implement Ownership check for "Commander Service Mode Config" record#2273
sk-keeper merged 1 commit into
releasefrom
fix/service-mode-config-owner

Conversation

@amangalampalli-ks

Copy link
Copy Markdown
Contributor

Summary

  • Prevent Service Mode from adopting or writing configuration from vault records the current account does not own.
  • Title-based lookup still works for owned records and integrations; shared or attacker-planted config records are ignored.

Changes

  • Require record_owner_cache ownership when resolving the Service Mode config record by title.
  • Add unit tests covering shared-only, shared-then-owned, and missing ownership-cache cases.

@amangalampalli-ks amangalampalli-ks self-assigned this Aug 7, 2026
@amangalampalli-ks
amangalampalli-ks marked this pull request as ready for review August 7, 2026 15:18
@sk-keeper
sk-keeper merged commit 9cbfc4e into release Aug 7, 2026
4 checks passed
@sk-keeper
sk-keeper deleted the fix/service-mode-config-owner branch August 7, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants