docs: say that the default questions read the visitor salt - #93
Merged
Conversation
The prop doc on `visitorSaltParameter` said that a deployment whose questions count no visitors never reads it and none has to exist. That is true, and it describes a case the defaults fall outside. `pageviews` counts visitors, and it is one of the five questions a deployment that passes no `rollups` gets. The prop, the props table in `docs/summary-schedule/` and "Which questions carry a count" in `docs/visitors/` now say that a default deployment reads the parameter, that it has to exist before the first run, and that a deployment wanting none passes `rollups` without a question that counts visitors. `rollup-summaries.test.ts` also loses a reference to a constant that no longer exists. #89 removed `viewsOnly` while #91 added a use of it, and main has not compiled since the two merged.
|
Warning Review limit reachedNext included review available in 15 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. Your 88 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prop doc on
visitorSaltParametersaid that a deployment whose questions count no visitors never reads it and none has to exist. That is true, and it describes a case the defaults fall outside.pageviewscounts visitors, and it is one of the five questions a deployment that passes norollupsgets. The parameter is therefore a prerequisite of a default deploy, and a stack that goes up without one loses bothpageviewsschedules on their first call while the other four questions keep computing. The prop now says that the default questions read it, that it has to exist before the first run, and that a deployment wanting none passesrollupswithout a question that counts visitors.docs/summary-schedule/says the same under the props table, next to what the permissions section already says aboutssm:GetParameterreading a parameter no template creates.docs/visitors/held the two halves of this in separate sections, and "Which questions carry a count" now carries both. The thinner copy of the doc onSummaryFunctionPropsis left alone, since that construct is not exported, never sees the rollups list, and takes the parameter from whatever chose the questions. One change here is unrelated to the issue. #89 removed theviewsOnlyconstant fromrollup-summaries.test.tswhile #91 added a use of it, and main has not compiled since the two merged, withpnpm checkfailing intscbefore it reaches a test. That case synthesises a stack and runs no query, and it takespageviewslike the deployment case above it.Resolves #87
Conventional commit message, used as the title
Conventional branch name, like
feat/concise-descriptionFull check with
pnpm run checkpassedRebased off latest main
User-facing behaviour is documented in
docs/See https://www.conventionalcommits.org/en/v1.0.0/