Add cl_khr_cooperative_matrix OpenCL C extension by asudarsa-qti · Pull Request #1627 · KhronosGroup/OpenCL-Docs

asudarsa-qti · 2026-09-29T17:33:37Z

No description provided.

…invocation update the sizeof operation description for coop matrix (result is total size for entire scope) add saturation modes fix various typos

Signed-off-by: Arvind Sudarsanam <asudarsa@qti.qualcomm.com>

…rpart

Signed-off-by: Arvind Sudarsanam <asudarsa@qti.qualcomm.com>

CLAassistant · 2026-09-29T17:34:01Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ asudarsa-qti
❌ tomasz-platek
❌ AlexGalazin-IMG
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

svenvh · 2026-10-22T14:00:57Z

+void coop_mat_store(const gentype *p, component_type __attribute__((coop_mat(...))) m, const coop_matrix_layout_t layout, const size_t _stride);
+component_type __attribute__((coop_mat(...))) coop_mat_mulAdd(component_type __attribute__((coop_mat(...))) A, component_type __attribute__((coop_mat(...))) B, component_type __attribute__((coop_mat(...))) C);
+component_type __attribute__((coop_mat(...))) coop_mat_mulAdd(component_type __attribute__((coop_mat(...))) A, component_type __attribute__((coop_mat(...))) B, component_type __attribute__((coop_mat(...))) C, coop_matrix_operands_t matrix_operands);
+uint coop_mat_length(component_type __attribute__((coop_mat(...))) m);


Is coop_mat_init missing from this list?

svenvh · 2026-10-22T14:01:48Z

+
+[source,c]
+----
+component_type __attribute__((coop_mat(...))) coop_mat_load(const gentype p, const coop_matrix_layout_t layout, const size_t stride);


Suggesting to manually line-wrap the longer lines here to improve readability.

svenvh · 2026-10-26T16:46:49Z

+=== (Add to Section 6.4.3. *Explicit Conversions*) :
+
+Conversions are allowed between cooperative matrix type only if
+the scope, row, column, and use parameters are the same.


Section 6.4.3 says

Explicit conversions may be performed using the

convert_destType(sourceType)

suite of functions.

Are we defining any new forms of convert_* here?

svenvh · 2026-10-27T09:50:49Z

I'm confused, there are 2 files with the same content now?

svenvh · 2026-10-27T10:04:34Z

+== Version
+
+Built On: {docdate} +
+Version: 1.0.0


This should be 2.0.0 I think; version 1 is #1533

svenvh · 2026-10-27T10:05:01Z

+
+[source,c]
+----
+__opencl_c_ext_cooperative_matrix


Suggested change

__opencl_c_ext_cooperative_matrix

__opencl_c_khr_cooperative_matrix

svenvh · 2026-10-27T10:06:55Z

+----
+
+enum coop_matrix_operands_t
+{


I think all of the enum values may need a _KHR suffix. And maybe the enums themselves and functions too, though I'm not 100% sure.

svenvh · 2026-10-27T10:08:03Z

+== Dependencies
+
+This extension is written against the OpenCL 3.0 C Language specification and the OpenCL SPIR-V Environment specification, V3.0.8.
+


Perhaps we should also mention the dependency on cl_khr_cooperative_matrix version 1.0.0 (which brings the API and SPIR-V parts)?

svenvh · 2026-10-27T10:11:36Z

+
+== Modifications to the OpenCL C Specification
+
+=== (Add a new Section 6.3.X, *Cooperative Matrix Type*) :


Suggested change

=== (Add a new Section 6.3.X, *Cooperative Matrix Type*) :

=== (Add a new Section 6.3.X, *Cooperative Matrix Types*) :

svenvh · 2026-10-27T11:12:15Z

+----
+coop_mat -> OpTypeCooperativeMatrixKHR
+coop_mat_init(scalar value) -> OpConstantComposite
+coop_mat_init(coop_mat) -> Op*Convert, OpConvert*To*


This variant of coop_mat_init isn't explained further down.

svenvh · 2026-10-27T11:22:19Z

+   If _layout_ is `CLK_COOPERATIVE_MATRIX_LAYOUT_COLUMN_MAJOR`,
+   then elements (*,col) of the result are taken in
+   order from contiguous locations starting at _p_ + _col_*_stride_.
+|  void **coop_mat_store**(const gentype *_p_, coop_mat _m_, const coop_matrix_layout_t _layout_, const size_t _stride_);


Suggested change

| void **coop_mat_store**(const gentype *_p_, coop_mat _m_, const coop_matrix_layout_t _layout_, const size_t _stride_);

| void **coop_mat_store**(gentype *_p_, coop_mat _m_, const coop_matrix_layout_t _layout_, const size_t _stride_);

?

svenvh · 2026-10-27T11:26:49Z

+enum coop_matrix_operands_t
+{
+  CLK_COOPERATIVE_MATRIX_OPERAND_NONE                                   = 0,
+  CLK_COOPERATIVE_MATRIX_OPERAND_MATRIX_A_SIGNED                        = 0x10,


Are we deliberately deviating from the SPV_KHR_cooperative_matrix "Cooperative Matrix Operands" values?

svenvh · 2026-10-27T11:28:14Z

+
+The arithmetic binary operators add (+), subtract (-), multiply (*), and
+divide (/) operate on cooperative matrix types and perform the operation
+component-wise. The operands must have identical types.


Should we say something about uniformity of the operands?

svenvh · 2026-10-27T11:37:16Z

+[cols="7,3",options="header",]
+|====
+| Function | Description
+| coop_mat **coop_mat_load**(const gentype *_p_, const coop_matrix_layout_t _layout_, const size_t _stride_)


This is a "first" for OpenCL I think: the full return type cannot be determined from the arguments/function name. Which means something like coop_mat_length(coop_mat_load(p, layout, stride)) cannot work?

AlexGalazin-IMG and others added 8 commits May 29, 2025 13:16

Draft of cl_ext_kernel_cooperative_matrix

fd23e06

add the coop_mat_length function to get the number of components per …

1636b89

…invocation update the sizeof operation description for coop matrix (result is total size for entire scope) add saturation modes fix various typos

Minor change to test if access is available

af3b044

Signed-off-by: Arvind Sudarsanam <asudarsa@qti.qualcomm.com>

Address review comments

bde12ea

Modify coop_mat_operands enum definition to reflect its SPIR-V counte…

92f5a8a

…rpart

Minor corrections

6632784

Signed-off-by: Arvind Sudarsanam <asudarsa@qti.qualcomm.com>

Update document

708de2f

Update scope information

81efdb8

asudarsa-qti mentioned this pull request Sep 29, 2026

[OpenCL][Clang] Add support for cooperative matrix extension llvm/llvm-project#221328

Open

anun333 mentioned this pull request Oct 15, 2026

WIP cl_khr_cooperative_matrix #1533

Open

svenvh reviewed Oct 26, 2026

View reviewed changes

Update enum values

b73efa3

svenvh reviewed Oct 27, 2026

View reviewed changes

	__opencl_c_ext_cooperative_matrix
	__opencl_c_khr_cooperative_matrix

		== Dependencies

		This extension is written against the OpenCL 3.0 C Language specification and the OpenCL SPIR-V Environment specification, V3.0.8.


		== Modifications to the OpenCL C Specification

		=== (Add a new Section 6.3.X, Cooperative Matrix Type) :

	\| void coop_mat_store(const gentype *_p_, coop_mat _m_, const coop_matrix_layout_t _layout_, const size_t _stride_);
	\| void coop_mat_store(gentype *_p_, coop_mat _m_, const coop_matrix_layout_t _layout_, const size_t _stride_);

Conversation

asudarsa-qti commented Sep 29, 2026

Uh oh!

CLAassistant commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CLAassistant commented Sep 29, 2026 •

edited

Loading