Repository navigation
Restrict Initializers for Workgroup OpVariables - #1638
Merged
Merged
Conversation
The OpenCL C specification states that a local variable must not have an initializer. Add a similar restriction to the OpenCL SPIR-V Environment specification. Fixes KhronosGroup#554 Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
bashbaug
approved these changes
Oct 27, 2026
bashbaug
left a comment
bashbaug
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Does spirv-val already check for this? If not, might be worth adding a SPIRV-Tools issue to track it.
Member
Author
I've opened KhronosGroup/SPIRV-Tools#7006 to add the check. |
Contributor
|
This should be non-controversial, so I'm going to go ahead and merge this. If more discussion is needed for some reason, we can always revisit. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenCL C specification states that a local variable must not have an initializer. Add a similar restriction to the OpenCL SPIR-V Environment specification.
Fixes #554