Repository navigation
Conversation
Signed-off-by: Kevin Petit <kevin.petit@arm.com> Change-Id: If1a8bffe6fad12785c726d5cc3ca3bca269fd360
bashbaug
reviewed
Oct 29, 2026
bashbaug
left a comment
bashbaug
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Feel free to merge this yourself if you'd like, otherwise let me know and I'll click the button.
Comment on lines
+74
to
+78
| typedef enum { | ||
| CL_KERNEL_EXEC_INFO_LOCAL_MEMORY_BACKING_GLOBAL_ARM = 1, | ||
| CL_KERNEL_EXEC_INFO_LOCAL_MEMORY_BACKING_COMPUTE_UNIT_ARM = 2, | ||
| CL_KERNEL_EXEC_INFO_LOCAL_MEMORY_BACKING_AUTO_ARM = 3, | ||
| } cl_kernel_exec_info_local_memory_backing_arm; |
Contributor
There was a problem hiding this comment.
FYI, maybe not a big deal, but this does not exactly match what gets generated for the headers.
typedef cl_uint cl_kernel_exec_info_local_memory_backing_arm;
...
/* cl_kernel_exec_info */
#define CL_KERNEL_EXEC_INFO_LOCAL_MEMORY_BACKING_GLOBAL_ARM 1
#define CL_KERNEL_EXEC_INFO_LOCAL_MEMORY_BACKING_COMPUTE_UNIT_ARM 2
#define CL_KERNEL_EXEC_INFO_LOCAL_MEMORY_BACKING_AUTO_ARM 3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.