Repository navigation
Conversation
Move is_property, is_property_v, is_property_of and is_property_of_v from <sycl/khr/split_headers/type_traits.hpp> to <sycl/khr/split_headers/property_list.hpp>, and update the summary table rows for both headers to match. The core specification defines these traits together with the property_list class in a single synopsis (see "Properties interface"), so the split header that provides property_list should provide them as well. Since, the extension has not been published yet, the feature test macro version is left at 1.
gmlueck
approved these changes
Oct 19, 2026
nliber
approved these changes
Oct 22, 2026
Contributor
|
Looking for a hero here to provide the final approval on this PR. It would be really nice to be able to include the split headers KHR in the next spec update release, and we plan to consider making that release in this week's WG call. The matching CTS PR is also ready for review: KhronosGroup/SYCL-CTS#1252 |
VerenaBeckham
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move is_property, is_property_v, is_property_of and is_property_of_v from <sycl/khr/split_headers/type_traits.hpp> to
<sycl/khr/split_headers/property_list.hpp>, and update the summary table rows for both headers to match.
The core specification defines these traits together with the property_list class in a single synopsis (see "Properties interface"), so the split header that provides property_list should provide them as well.
Since, the extension has not been published yet, the feature test macro version is left at 1.