build: Update required CMake version to 3.28.3 - #1975
Open
charles-lunarg wants to merge 2 commits into
Open
Conversation
Also removed workarounds for older CMake versions.
|
CI Vulkan-Loader build queued with queue ID 41691. |
|
CI Vulkan-Loader build queued with queue ID 41708. |
Updates github actions to use Ubuntu 26.
|
CI Vulkan-Loader build queued with queue ID 41757. |
Collaborator
Author
Collaborator
Author
|
CI failure is due to older CMake version. Will have to audit and update CI machines before this can be merged.
|
|
CI Vulkan-Loader build # 3640 running. |
|
CI Vulkan-Loader build # 3640 failed. |
jpr42
approved these changes
Jul 15, 2026
jpr42
suggested changes
Aug 4, 2026
Contributor
There was a problem hiding this comment.
Highly recommend adding this as the standard way for package managers to disable warnings as errors while keeping life simple for devs
# https://cmake.org/cmake/help/latest/variable/CMAKE_COMPILE_WARNING_AS_ERROR.html
# Override at the command line with --compile-no-warning-as-error
set(CMAKE_COMPILE_WARNING_AS_ERROR ON)
| endif() | ||
|
|
||
| # Enable IDE GUI folders. "Helper targets" that don't have interesting source code should set their FOLDER property to this | ||
| set_property(GLOBAL PROPERTY USE_FOLDERS ON) |
Contributor
There was a problem hiding this comment.
This can be removed now see https://cmake.org/cmake/help/latest/policy/CMP0143.html#policy:CMP0143
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removed workarounds for older CMake versions.
FYI @JP42Edit: Pinged the wrong person, apologies