fix whole-wildcard and short prefix globs in determine_filter_type - #1990
Open
aizu-m wants to merge 1 commit into
Open
fix whole-wildcard and short prefix globs in determine_filter_type#1990aizu-m wants to merge 1 commit into
aizu-m wants to merge 1 commit into
Conversation
|
Author aizu-m not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author aizu-m not on autobuild list. Waiting for curator authorization before starting CI build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting the select filter to the whole-wildcard form leaves no usable driver:
Found this reading
determine_filter_typefor something unrelated.**is one of the threewhole-wildcard forms next to
*and~all~, so it should have matched every name.Both branches that classify a token as
FILTER_STRING_SPECIALassign the type and then fallthrough into the star_begin/star_end classification below, which overwrites it.
**comes outas a suffix filter on
*, and no manifest or layer name ends in a star. Thefilter_length == 2test also never checked the leading character, so a two character glob like
A*took that samebranch and ended up
FILTER_STRING_FULLNAMEon the literalA*rather than a prefix onA.Worth noting the disable direction fails open:
VK_LOADER_LAYERS_DISABLE=**sets neitherdisable_allnor a filter that can match, so every layer stays enabled.Returning once a token is classified special, and requiring the leading star for the two
character case, fixes both. Every other glob form classifies exactly as before.