Repository navigation
Refine pull request template for clarity and detail - #8
Conversation
Updated the pull request template to clarify sections on description, changes included, and testing instructions.
| **How to test:** | ||
|
|
||
| - Add instructions on how to run here | ||
| - Steps to reproduce the issue and what happens now, or where to find the feature (preview link, page, flag, required plan or data) and what to expect. Do not list lint, type checks, or tests; CI runs them |
There was a problem hiding this comment.
not everything is an issue, would phrase it more general.
I wouldn't put a hard restriction to exclude tests, some PR are best "tested" by running a certain test before and after and see the difference from that
There was a problem hiding this comment.
not everything is an issue, would phrase it more general.
I agree
I wouldn't put a hard restriction to exclude tests, some PR are best "tested" by running a certain test before and after and see the difference from that
I do not understand this. Tests are already adjusted to pass if your PR is ready for review. Or, do you mean adjusting the runtime logic while preserving the newer tests and intentionally failing the test so we can verify that the test is catching bugs? If so, then I am in agreement.
There was a problem hiding this comment.
yeah. Whether a test is passing is checked by CI. but for some PRs the best way to test them is to run a specific test under different parameters or just see how test timing is changing. I don't think this is a super recurring case, I would just avoid to put a hard limit on it
There was a problem hiding this comment.
Updated both PRs in regards to hard limiting the inclusion of test.
Updated the testing instructions for clarity on how to test changes.
Description:
Aligns the shared PR template with https://github.com/Kittl/mono/pull/15939
How to test:
Checklist (based on PR guidelines):