Skip to content

Spike bench nits: corpus byte-count off-by-3, ruff format, report rows column #91

Description

@valiantone

Summary

Small accuracy/style nits found in local review of the spike bench code (#84). Non-blocking for merge; fix if the bench is ever re-run.

Findings

  1. bench/native_spike/gen_corpus.py:171written += 38 but the malformed line is 41 bytes (40 + newline). Only skews the ~60% insertion threshold and final size by 3 bytes; bad_line_offset is recorded pre-write, so manifest correctness is unaffected.
  2. bench/native_spike/run_bench.py fails ruff format --check (bench/ is not CI-enforced; one ruff format pass fixes).
  3. bench/native_spike/run_bench.py:314 — the report's "rows" column takes the first arm's value blindly; parity is asserted separately, so cosmetic only.

Context

Local code review of #84 before merge; see bench/native_spike/README.md for the spike itself (#48).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:benchmarksEval harness, LOCOMO benchmarks, provider comparisonsenhancementNew feature or requestpriority:p3Later optimization; implement only when benchmarks justify complexityv0.2.xHotMem post-v0.2 follow-up work

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions