Skip to content

mkdocs. Mapping tables apis. Fix #1032#1043

Merged
dgarijo merged 6 commits into
KnowledgeCaptureAndDiscovery:devfrom
juanjemdIos:fix-1032
Jul 3, 2026
Merged

mkdocs. Mapping tables apis. Fix #1032#1043
dgarijo merged 6 commits into
KnowledgeCaptureAndDiscovery:devfrom
juanjemdIos:fix-1032

Conversation

@juanjemdIos

Copy link
Copy Markdown
Contributor

No description provided.

@dgarijo dgarijo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending changes

Comment thread docs/codeberg.md Outdated

*1*
Extracted by fetching the LICENSE file via `GET /api/v1/repos/{owner}/{repo}/contents/{filename}` (tries `LICENSE`, `LICENSE.md`, `LICENCE`, `COPYING`). The content is base64-decoded and analyzed with `detect_license_spdx()` to obtain the SPDX identifier, name and URL. Technique: `Codeberg_API`. No newline at end of file
Extracted by fetching the LICENSE file via `GET /api/v1/repos/{owner}/{repo}/contents/{filename}` (tries `LICENSE`, `LICENSE.md`, `LICENCE`, `COPYING`). The content is base64-decoded and analyzed with `detect_license_spdx()` to obtain the SPDX identifier, name and URL.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be this way. We do the inspection of the files offline, so this behavior should not happen if the API does not support licenses.

Comment thread docs/bitbucket.md Outdated
`https://bitbucket.org/{owner}/{repo}/get/{branch}.zip`

Bitbucket archive URLs typically include a `Content-Length` header, so the size limit check
can be performed before downloading.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last comment, I don't know who is targeted to. Please remove

Comment thread docs/bitbucket.md Outdated
without byte counts per language.
- **CODEOWNERS enrichment**: Not supported for Bitbucket, as the platform does not
expose a public user API.
- **Rate limits**: Unauthenticated requests are limited to 60 requests/hour.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already add a means to address rate limits. We indicate how to do this in the readme, no? I think this part is not needed

Comment thread docs/codeberg.md
- **Rate limits**: Unauthenticated requests are limited to 60 requests/hour. Authenticated
requests (via `codeberg-token`) have higher limits. Create a token at
`https://codeberg.org/user/settings/applications`.
- **License detection**: Codeberg does not provide a `license` field in the repository

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per above, this should be removed

Comment thread docs/github.md Outdated

- **No Content-Length**: GitHub archive downloads lack a `Content-Length` header, so the
size limit check relies on streaming (reading 1 MB chunks until the limit is exceeded).
- **Rate limits**: Unauthenticated requests are limited to 60 requests/hour. Authenticated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already address this in the config, so it's not a limitation

Comment thread docs/github.md Outdated
requests (via `github-token`) are limited to 5,000 requests/hour.
- **Private repositories**: SOMEF cannot access private repositories without a valid token.
- **Asset download count**: GitHub provides `download_count` for release assets; other
providers may not offer this field.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This last thing, I am not sure we need it

Comment thread docs/gitlab.md Outdated
- **Self-hosted detection**: SOMEF detects self-hosted instances by checking for `gitlab.com`
in the URL. If a self-hosted instance uses a custom domain without a GitLab API endpoint,
detection may fail.
- **Rate limits**: GitLab.com unauthenticated requests are limited to 600 requests/hour.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already addressed. Remove

Comment thread docs/gitlab.md Outdated
- **Rate limits**: GitLab.com unauthenticated requests are limited to 600 requests/hour.
Authenticated requests (via `gitlab-token`)have higher limits depending on the token type. Self-hosted
instances have their own rate limits.
- **Programming languages**: GitLab returns only language names (no byte counts).

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a problem. Remove

Comment thread src/somef/process_repository.py
@dgarijo dgarijo merged commit 065e184 into KnowledgeCaptureAndDiscovery:dev Jul 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants