Skip to content

Show local Windows administrator shields across tab layouts - #449

Merged
Kuddev merged 7 commits into
Kuddev:mainfrom
WilliamWang1721:codex/issue-436-admin-indicator
Oct 6, 2026
Merged

Kuddev merged 7 commits into
Kuddev:mainfrom
WilliamWang1721:codex/issue-436-admin-indicator

Conversation

@WilliamWang1721

@WilliamWang1721 WilliamWang1721 commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Result / 用户结果

Elevated local Windows terminal tabs show a persistent 🛡 indicator in the sidebar, top tabs and the active title when the sidebar is collapsed. The shared badge has an accessible label and tooltip identifying the local Pebrel administrator context. Closes #436.

Design / 设计边界

Reuse the existing cached Windows token query and show the badge only after confirmed elevation. The focused pane must belong to the local host: managed SSH, nested SSH history scopes and WSL contexts are excluded, including mixed split tabs. Settings/document tabs never acquire the badge. A static indicator stays readable with reduced motion and adds no animation timer. Existing tab activity, selection, close and drag controls remain independent.

Evidence / 验证依据

Final head e601dd0de58a5eac8f28838ce7c5e037d0d025cc: architecture, lint, PR size and all required reports passed. Upstream validation executed Linux; contributor fork run 37101266522 additionally passed all five native platforms on the same head. This is automated native-suite evidence; platform/device UI limits below still apply.

Two self-review passes completed. New regressions exercise real terminal-view context classification and render the shared badge beside a title with reduced motion enabled and disabled. Final-head GitHub Actions validation passed; the final-head contributor-fork five-platform native run also passed. No local automated checks were run. Manual elevated Windows visual/screen-reader acceptance is not claimed.

AI implementation/review: GPT-6.1 SOL sub-agents; coordinator model and reasoning efforts unverified.

Required Review / 必须确认

  • Followed contributing, architecture, project constraints and typed i18n rules.
  • Reused the token authority and one shared badge; no persistent format, thread or dependency added.
  • Final-head formatting, architecture, selected native checks and every required context passed.
  • Automated and manual validation boundaries are stated; no existing test was removed.

Additional final-head fork native validation: five-platform run. This does not claim manual UAC or privileged-window visual acceptance.

@WilliamWang1721
WilliamWang1721 marked this pull request as ready for review October 3, 2026 06:40
@Kuddev

Kuddev commented Oct 6, 2026 •

Copy link
Copy Markdown
Owner

已按维护者确认的设计直接调整,并同步最新 main(包含 #496、#497)。当前 head:db16e4e83b6cf2265c2a684fc9e81b3dcb6cc31a。

  • 侧栏、顶部标签、侧栏收起后的活动标题统一为:管理员盾牌 → 程序/AI 图标 → 名称。
  • 盾牌复用 TAB_LABEL_ICON_SIZE,与任务图标同为 15 逻辑像素;改为随产品编译嵌入的矢量图,不依赖 emoji 字体。
  • 保留悬停提示与无障碍名称,不闪烁、不新增动画定时器。程序/AI 图标变化不替换权限标记。
  • 保留本机管理员判断和 SSH/WSL 排除,不把标记挂在 TABS 数量旁误指整个列表。
  • 现有布局回归加强为:盾牌与任务图标尺寸相同,且盾牌在程序图标及标题之前;保留减少动效条件和本机/远端分类回归。

格式、架构、平台条件预算、diff 检查已通过。本地 Windows 测试构建以退出码 1 结束,输出未包含编译错误或构建完成记录,正在核对进程状态;新 head 的上游检查也已触发;旧 head 的通过结果不当作新 head 的验收结果。

@Kuddev Kuddev left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

复核当前 head db16e4e。按维护者最终确认,侧栏、顶部标签和侧栏收起标题均采用“盾牌 → 程序/AI 图标 → 名称”;盾牌与任务图标共用 TAB_LABEL_ICON_SIZE(15 逻辑像素),使用编译期嵌入的矢量资源,保留悬停说明与无障碍名称。盾牌独立于程序图标,不闪烁、不添加定时器。

权限判定复用已缓存的 Windows token 查询,只标记确认继承本机上下文的终端,排除 SSH、WSL、缺少上下文和非终端页面。逐项核查了 10 个差异文件,未发现无关功能、推广内容、依赖或持久化变更。

验证:当前 head 的 Linux 实际原生套件与十项必需检查通过;本机 Windows 从该 head 构建的两项定向回归均通过,分别验证等尺寸/顺序/减少动效,以及本机/远端上下文边界。首次本地构建异常退出未给出诊断,确认原进程退出后在未改源码的情况下重新构建成功,保留两次日志。未声称人工 UAC 窗口、读屏或所有 DPI 的视觉验收。

@Kuddev
Kuddev merged commit 9d30afe into Kuddev:main Oct 6, 2026
12 checks passed
@WilliamWang1721
WilliamWang1721 deleted the codex/issue-436-admin-indicator branch October 11, 2026 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] 强化Windows中的管理员权限提示

2 participants