Repository navigation
feat(agents): configure explicit automatic resume arguments - #457
Open
WilliamWang1721 wants to merge 33 commits into
Open
WilliamWang1721 wants to merge 33 commits into
WilliamWang1721 wants to merge 33 commits into
Conversation
1 task done
This was referenced Oct 9, 2026
Contributor
|
我想知道这个分支近期还有打算继续进行吗?我日常使用还比较需要这个功能,如果近期没有打算我就自己动手了 |
Contributor
Author
|
@Cec1c 本 PR 仍然在持续跟进,只要把这个修复了就可以 mark 成 open,但是遗憾的是 owner 对于 PR 的审核速度,这将决定了这个 PR 何时能够成功 merge。由于 owner 并没有开启为其他的贡献者的维护者权限,也没有开启相互 review 权限,因此只能等待,预计这个 PR 剩余的冲突将会在今天晚上完成。 |
…-resume-args # Conflicts: # .config/nextest.toml
WilliamWang1721
marked this pull request as ready for review
October 10, 2026 13:09
…-resume-args # Conflicts: # nebula_settings/src/reset.rs
# Conflicts: # .config/nextest.toml # scripts/tests/test_ci_native_tests.py
# Conflicts: # .config/nextest.toml
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result / 用户结果
Closes #323. The GPUI Agent page now saves explicit per-Agent automatic-resume arguments as a JSON array, for example
["--yolo"]for Codex. Missing/empty configuration and[]keep the default command;[""]passes an explicit empty argument. No permission flag is enabled automatically and command history is never replayed.Design / 设计边界
agent_resume_args_<source>keys and reset behavior. The application parses literal JSON arrays;platform/agent_resumeadapts native argv using existing shell quoting and Windows encoding. No dependency is added.%and!. Manual palette resume, forks, runtime Agent start and legacy shell UI retain their existing scope.Evidence / 验证依据
Current source head:
7b4004409c2835a238f1c2c4a925ac0509f12146, based on upstream9dd3d6491bfaaf902a4a3a248c02f36a47abae2d.b8ffd92achecks out the exact source head above. It exercises real input, keyboard Save, success/error feedback and clearing; it is not upstream CI.At least two author self-reviews completed, with changed diffs re-reviewed after repairs. All execution, formatting, architecture and builds run in GitHub Actions; no local automated tests/builds were run. Earlier-head passes are not claimed for this head. Native DPI/long-language and real provider CLI acceptance remain pending.
AI-assisted implementation and author self-reviews: GPT-6.1 SOL, reasoning effort high. Independent review supplied the linked native argv reproduction; its model/effort was not confirmed in this chat.
Required Review / 必须确认