Repository navigation
fix(ui): pointer cursor on toolbar buttons, larger notification close target, inset macOS title bar controls - #502
Open
WilliamWang1721 wants to merge 21 commits into
Conversation
… target, inset right title bar controls on macOS
WilliamWang1721
marked this pull request as ready for review
October 6, 2026 14:12
Kuddev
requested changes
Oct 6, 2026
Kuddev
left a comment
Owner
There was a problem hiding this comment.
当前 head 43586a5 的两个问题需要调整后合并:
toast.rs::with_close_target将热区固定在外层容器 top/right=0,但被包装的 Notification 自身有进入/退出位移动画。锁定依赖的 notification.rs:374 起通过相对 left 位移移动卡片,而外层热区不跟随,动画期间图标与命中位置会分离。关闭范围扩大应与实际卡片几何及生命周期保持一致;请补进入/退出过程、卡片自身 on_click 不触发、多个通知分别关闭的交互覆盖,不能只测静止后的单张卡片角落。widgets::toolbar_button无条件 cursor_pointer,现有 sidebar.rs 的 disabled(settings_active) 和 details_panel.rs 的 disabled(reader_focus) 仍会显示可操作手型。请保留禁用状态的指针语义。
macOS 留白属于独立布局调整,手型及动画热区也还缺实际视觉证据。这里不更改依赖版本或复制另一套通知动画来凑合修复;请按上述边界调整后复审。
Kuddev
reviewed
Oct 6, 2026
Kuddev
left a comment
Owner
There was a problem hiding this comment.
已复核新 head 90bd138。前一轮两个实现问题已有实质修正:
- 去掉固定关闭覆盖层,改用锁定版本 Notification 自己的 on_click → dismiss 路径,点击区域与卡片共享位移动画;关闭按钮内部 stop_propagation,dismiss 本身也处理重复关闭。
- toolbar_button 显式接收 disabled,仅启用时加手型;侧栏、设置、命令列表和右侧栏调用点已对应调整。没有新增依赖或复制动画状态机。
当前 macOS ARM64 失败日志不是这些产品修改导致的:test_isolated_launch_discards_parent_routing_and_config_overrides 将 /var 临时目录与启动器规范化后的 /private/var 路径直接作字符串比较。主线夹具问题由 #508 修复,请勿通过改通知代码、放宽原生检查或反复重跑掩盖它。#508 合入后我会继续核查当前 PR 的原生结果。
仍待验证:新增整卡关闭回归的实际执行结果;macOS 12px 内缩与两种标签布局的真实外观/命中证据。原改名测试的共享设置分组也请随最新 main 保留。本次记录不代表已经完成真实平台视觉验收。
# Conflicts: # nebula_app/src/gpui_shell/workspace/sidebar.rs # nebula_app/src/gpui_shell/workspace/top_tabs.rs
# Conflicts: # nebula_app/src/gpui_shell/workspace/details_panel.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advertising, commercial promotion, and traffic solicitation are prohibited in PRs
and Issues. Business requests must go through the email in the
contribution policy.
PRs or Issues containing unauthorized promotion will be closed directly.
严禁利用 PR 或 Issue 推广、引流,未经授权的推广将直接关闭;商业需求请通过贡献指南中的邮箱沟通,已获批准的赞助按批准范围处理。
Result / 用户结果
cursor_default,toolbar_button现在显式接收disabled决定指针。on_click关闭路径,命中区即卡片本身,随进入/退出位移动画移动。platform::window_chrome::trailing_inset提供。Design / 设计边界
widgets::toolbar_button、toast::note/toast、window_titlebar::title_bar_right_controls、platform::window_chrome。platform/;通知生命周期与动画仍由组件库负责。stop_propagation处理,行为不变。Evidence / 验证依据
clicking_a_toast_card_dismisses_only_that_card,两条 toast 并存时点击最新卡片只关闭它。Required Review / 必须确认
CONTRIBUTING.md,docs/architecture.md, anddocs/project-constraints.md.python3 scripts/check_architecture.py --base <PR-base-commit>passes; budgets were not inflated to fit the change.Checkboxes explain the review; they do not replace CI or maintainer approval.