Skip to content

feat(windows): let PowerShell keep its own ls/dir via builtin_ls=0 - #615

Open
WilliamWang1721 wants to merge 15 commits into
Kuddev:mainfrom
WilliamWang1721:fix/issue-549-5gzczi
Open

WilliamWang1721 wants to merge 15 commits into
Kuddev:mainfrom
WilliamWang1721:fix/issue-549-5gzczi

Conversation

@WilliamWang1721

Copy link
Copy Markdown
Contributor

Result / 用户结果

Windows PowerShell tabs can now keep PowerShell's own ls/dir by setting builtin_ls=0 in pebrel_settings.txt. The default is unchanged: Nebula's ls/ll/dir listing stays on. Closes #549.

Design / 设计边界

  • Responsibility and affected modules: the PowerShell integration script in nebula_terminal/src/tty/windows/mod.rs; the ls/ll/dir alias block now sits behind the existing Get-NebulaBoolSetting helper.
  • Why this belongs here; interfaces that remain unchanged: the aliases are created by this script, so the opt-out lives next to them. Nebula-List stays defined; no Rust API, settings UI or persistence format changes (unknown keys are already preserved).
  • Dependency, data-format, threading, or lifetime changes (ADR if applicable): none.
  • Compatibility and migration/fallback behavior: key absent or invalid means the built-in listing, as before.

Evidence / 验证依据

  • Commands and actual results (include unrun checks): not run locally; relying on PR CI.
  • Regression tests: builtin_ls_aliases_can_be_opted_out checks the aliases sit behind the builtin_ls gate.
  • UI changes: none.
  • Hot-path changes: none.

Required Review / 必须确认

  • I followed CONTRIBUTING.md, docs/architecture.md, and docs/project-constraints.md.
  • I split responsibilities, not arbitrary line ranges; no duplicate behavior authority was added.
  • python3 scripts/check_architecture.py --base <PR-base-commit> passes; budgets were not inflated to fit the change.
  • Tests cover success and failure; platform/feature coverage limitations are stated.
  • New messages use typed i18n IDs and matching placeholders; untranslated content has an explicit fallback.
  • Governance changes include a counterexample, corrected contract, tests, and a maintainer-reviewed decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] ls 支持使用系统默认命令

1 participant