Repository navigation
feat(terminal): name local AI-agent tabs after the reported task title - #616
Open
WilliamWang1721 wants to merge 15 commits into
Open
WilliamWang1721 wants to merge 15 commits into
WilliamWang1721 wants to merge 15 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result / 用户结果
When several Claude Code or Codex tabs run in the same directory, each local tab is now labelled with the task title the agent reports (OSC 0/2), so they can be told apart. The animated leading status glyph is stripped. The label falls back to the directory name when the agent only reports its own name or when it exits; SSH tabs, custom names and other programs are unchanged, and the tooltip keeps the directory and agent name. Fixes #475.
Design / 设计边界
TerminalView::tab_labelinnebula_app/src/gpui_shell/terminal/view/tab_identity.rs; the tooltip's existing task detection moved into one shared helper so label and tooltip cannot disagree.tab_labeland needs no change beyond a comment.Evidence / 验证依据
ai_tab_is_named_after_reported_task_but_not_stale_task(startup_tests.rs) now asserts the task label, glyph stripping, fallback to the directory name, and no stale label after the command ends.Required Review / 必须确认
CONTRIBUTING.md,docs/architecture.md, anddocs/project-constraints.md.python3 scripts/check_architecture.py --base <PR-base-commit>passes; budgets were not inflated to fit the change.