Repository navigation
Conversation
ventupx
force-pushed
the
fix/shared-window-opacity
branch
from
October 21, 2026 07:54
238441c to
f1d9f2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result / 用户结果
The opacity slider now affects both terminal and Settings backgrounds while leaving text and dialogs opaque. Intermediate values such as 80% remain visible because the window root no longer adds a second opaque/background fill.
Design / 设计边界
The workspace card remains the single owner of content background alpha; Settings stops painting a second background. Root initialization and later background refresh both use a transparent fill, including when native wallpaper is absent. Existing material/wallpaper ownership and saved opacity values are preserved; no new configuration format or dependency is introduced.
This focused branch starts from upstream
8d6295595e084a12f9c2fe159f65c2dcd332d866. It excludes fork release/version/package metadata. Under the repository'spr-sizeexclusions, it changes 151 counted lines, within the 1500-line default.Evidence / 验证依据
Executed on Windows against this branch:
python scripts/check_architecture.py --base upstream/main— passed; existing budgets unchanged.python -m unittest scripts.tests.test_architecture_budgets scripts.tests.test_architecture_dependencies scripts.tests.test_architecture_governance— successful (55 tests, 3 platform-specific skips).cargo test --manifest-path tools/i18n-contract/Cargo.toml --locked— 24 passed, 1 existing ignored test.cargo test -p nebula-settings --locked— 99 passed.cargo test -p nebula --test file_line_budget --locked— 2 passed.cargo fmt --all -- --checkandgit diff --cached --check— passed.cargo check -p nebula --bin pebrel --features gpui-test-support --tests --locked— passed.cargo test -p nebula --bin pebrel --features gpui-test-support --locked --no-run— passed. Targeted GPUI tests use the same interaction-test feature as upstream CI and the filters below with-- --test-threads=1: 28 passed.Filters:
gpui_shell::theme::,wallpaper::tests::,setting_help::tests::,workspace::settings_navigation::ui_tests::.Regression coverage: A real GPUI Root stays transparent after initialization and opacity refresh; terminal and Settings alpha track 100/80/50/20/0% in dark/light themes; text and dialog backgrounds remain opaque; wallpaper request/cache/layout regressions are covered.
Localization: The title and concise description use typed messages in all 11 supported locales, describing the shared background behavior.
Visual/platform scope: the integrated changes were manually reviewed in a Windows preview before this split. These branch checks exercise rendered hitboxes/state and keyboard input where applicable; new screenshot captures and a DPI matrix were not run for this head. Linux/macOS current-head validation is left to upstream CI. The earlier full integrated-source validation passed 24 jobs at
6e86ea5c3ff29671043dfc62a788f1d4fde80732; that is supplemental evidence, not a check result for this PR head.Runtime cost: Removes duplicate background painting; uses the existing live refresh path. No new polling or background task and no dedicated compositing benchmark.
Required Review / 必须确认
CONTRIBUTING.md,docs/architecture.md, anddocs/project-constraints.md.