Repository navigation
Conversation
…ocess-exit-20261020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result / 用户结果
Adds Windows installer updates from administrator windows, including next-launch scheduling and recovery at the original privilege level. Previously these actions rejected elevated windows; removing that guard alone could neither save their workspace nor safely execute a plan stored in ordinary writable settings.
Refs #672 and #349. This also fixes the process-exit race that could pass an empty module path to
GetFullPath. Packaged Inno installation and full application recovery remain acceptance work, so this PR stays draft.Design / 设计边界
architecture/notes/nebula_app/.Evidence / 验证依据
8d629559. The actual newly built test executable passed 36 targeted Windows tests across updater, private storage, session persistence, administrator handover and GPUI recovery. Its path and SHA were checked against Cargo's artifact output.git diff --checkpassed. The new settings-writing UI fixture joins the existing serialized group alongside the provider fixture.7800d4ec(run). Windows ARM passed the failed-job rerun after an intermittent existing Git Bash wrapped-backspace failure; no unrelated production change was made.Required Review / 必须确认
These checks do not replace CI or maintainer review.