Skip to content

perf improvement to char array serialisation #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sshanks-kx merged 1 commit into from
Aug 12, 2026
Merged

perf improvement to char array serialisation #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion kx/c.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
/// This class is essentially a serializer/deserializer of .NET types
/// to/from the KDB+ IPC wire format, enabling remote method invocation in KDB+ via TCP/IP.
/// </remarks>
public class c : IDisposable

Check warning on line 21 in kx/c.cs

View workflow job for this annotation

GitHub Actions / build 

The type name 'c' only contains lower-cased ascii characters. Such names may become reserved for the language.

Check warning on line 21 in kx/c.cs

View workflow job for this annotation

GitHub Actions / build 

The type name 'c' only contains lower-cased ascii characters. Such names may become reserved for the language.
{
private readonly Socket _socket;

Expand Down Expand Up @@ -1174,7 +1174,7 @@
}
if (x is char[] carray)
{
return e.GetBytes(carray).Length;
return e.GetByteCount(carray);
}
return ((Array)x).Length;
}
Expand Down Expand Up @@ -2136,7 +2136,11 @@
{
int j = s.IndexOf('\0');
j = ((-1 < j) ? j : s.Length);
#if NETSTANDARD2_1_OR_GREATER || NETCOREAPP2_0_OR_GREATER
return e.GetByteCount(s, 0, j);
#else
return e.GetBytes(s.Substring(0, j)).Length;
#endif
}

private static string i2(int i)
Expand Down
Loading