GH-3: Write a script to check websites trilingual feature by ChanukaUOJ · Pull Request #4 · LDFLK/WebsiteScorecard

ChanukaUOJ · 2026-06-22T13:30:34Z

This PR introduces the trilingual check for WebsiteScorecard, which automatically detects whether websites support Sri Lanka's three official languages (English, Sinhala, and Tamil).

Changes

New Check Added: Implemented TrilingualCheck in src/websitescorecard/checks/trilingual.py.
Dependency Updates: Added playwright to the core pyproject.toml dependencies. Moved pytest-playwright and pytest-mock to [dev] dependencies.
Documentation: Updated README.md to document the new trilingual check, the required block-letter outputs, and instructions for running the required playwright install chromium setup step.
Base Checker: Updated base.py to support the new outputs.

Detection Pipeline

The script employs a multi-layered detection strategy to maximise accuracy, falling back to heavier methods only when necessary:

HTML Attributes: Checks the root <html lang="X"> and <link rel="alternate" hreflang="X"> tags.
Google Translate: Detects native and GTranslate widget implementations.
URL Localization: Uses regex to identify language-specific path segments (e.g., /si/, /en/) or query parameters (e.g., ?lang=ta).
Unicode Content Check: Parses the DOM and single-pass traversal of leaf text nodes to accurately count Sinhala, Tamil, and English characters without duplication.
Headless Browser Fallbacks: For JavaScript-heavy or single-page apps (SPAs), the script uses Playwright to:
- Verify that Google Translate widgets actually contain the required languages.
- Simulate clicks on visible language switcher buttons and verify the resulting DOM.
- Inject target language codes directly into localStorage (e.g., i18n, lang) and reload the page to detect locale changes.
Internal Link Crawling: As a last resort, scrapes internal links for language-specific URLs to fetch and verify.

Robustness & Fixes Included

Block-letter Outputs: Outputs standardised statuses (TRILINGUAL, NON_TRILINGUAL, TIMEOUT, UNREACHABLE) and detailed metadata (trilingual_details).

Testing

Added a comprehensive pytest suite (tests/test_trilingual.py) achieving full coverage of static and headless browser workflows.
Successfully ran scans against the sample data/mins_depts_test.csv file without errors.

gemini-code-assist

Code Review

This pull request introduces a new trilingual check to scan websites for English, Sinhala, and Tamil content using BeautifulSoup and Playwright, updating the README and project dependencies accordingly. The review feedback highlights several critical improvements: removing an unnecessary global lock to enable true concurrency, avoiding fragile string interpolation in page.evaluate, correcting the fallback logic for injection tests and URL construction, and preventing the masking of internal exceptions. Additionally, it is recommended to use playwright instead of pytest-playwright in production dependencies, move warning disabling to the module level, enhance the URL localization regex, wrap long lines, and document the Playwright browser installation prerequisite in the README.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

gemini-code-assist

Code Review

This pull request introduces a new TrilingualCheck to evaluate whether websites support English, Sinhala, and Tamil, updating the CLI, documentation, and dependencies accordingly. The review feedback highlights several important areas for improvement: resolving a concurrency bottleneck caused by a global Playwright lock, preventing browser resource leaks, securing JavaScript evaluations against injection, refining the English language detection regex to avoid false positives, preserving URL path and query parameters during checks, and exposing actual exception details instead of a hardcoded error message. Additionally, the production dependencies should be updated to use playwright instead of the testing plugin pytest-playwright.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

…ENT)

ChanukaUOJ · 2026-06-25T18:13:10Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a new TrilingualCheck to verify if websites support English, Sinhala, and Tamil, along with corresponding CLI options, documentation updates, and comprehensive tests. Feedback on the implementation highlights critical concurrency issues with shared instance state (_had_timeout) across threads, potential resource leaks of Chromium processes under exception paths, text duplication bugs in unicode content detection, and a double www. prefix bug in the fallback request logic.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

zaeema-n · 2026-06-26T09:22:18Z

+            found_langs.add(soup.html.get('lang').split('-')[0].lower())
+
+        missing = [lang for lang in LANGUAGE_KEY if lang not in found_langs]
+        return (len(missing) == 0, missing)


Why do we pass len(missing) == 0 and also missing? Can't we get all the info just from missing?

zaeema-n · 2026-06-26T09:31:37Z

+        if soup.find(id=HTML_GOOGLE_TRANSLATE_ELEMENT):
+            return 'google_translate'
+        if soup.find(class_=HTML_GOOG_TE_COMBO):
+            return 'google_translate'


Suggested change

if soup.find(id=HTML_GOOGLE_TRANSLATE_ELEMENT):

return 'google_translate'

if soup.find(class_=HTML_GOOG_TE_COMBO):

return 'google_translate'

if soup.find(id=HTML_GOOGLE_TRANSLATE_ELEMENT) or soup.find(class_=HTML_GOOG_TE_COMBO):

return 'google_translate'

zaeema-n · 2026-06-26T10:30:53Z

+                found_langs.add(lang)
+
+        missing = [lang for lang in LANGUAGE_KEY if lang not in found_langs]
+        return (len(missing) == 0, missing)


Why do we pass len(missing) == 0 and also missing? Can't we get all the info just from missing?

zaeema-n · 2026-06-30T04:28:53Z

+        for link in soup.find_all(HTML_KEY_LINK, rel=HTML_KEY_ALTERNATE):
+            hreflang = link.get(HTML_KEY_HREFLANG)
+            href = link.get('href')
+            if not hreflang:
+                continue
+            if href:
+                absolute_url = urljoin(url, href)
+                href_domain = urlparse(absolute_url).netloc
+                if href_domain.startswith('www.'):
+                    href_domain = href_domain[4:]
+
+                # Check if href domain is the same or a subdomain
+                if base_domain and not href_domain.endswith(base_domain):
+                    continue
+            hreflangs.append(hreflang)


In situations where there is a hreflang but no href it will still be accepted. For example:

<link rel="alternate" hreflang="en" />

Is there a reason for this?

zaeema-n · 2026-06-30T06:28:50Z

+            if len(found_langs) == 3:
+                return TrilingualCheckResult(status="TRILINGUAL", error=None, details=", ".join(passed_criteria))


If the basic checks pass then we don't do the deeplink checking. This does not catch the case where only the home page is translated and not the other pages. Better to not return here but continue checking the deeplinks for the same basic checks.

zaeema-n · 2026-06-30T06:31:54Z

+                if re.search(r'(?:/si(?:[/?#]|$)|/ta(?:[/?#]|$)|[?&]lang=(?:si|ta)(?:&|$)|/sinhala|/tamil)', href_lower) or \
+                   any(x in text for x in ['sinhala', 'tamil', 'සිංහල', 'தமிழ்']):


Why not english?

zaeema-n · 2026-06-30T06:33:53Z

+            # Filter out the homepage itself
+            internal_links = [l for l in internal_links if l != response.url and l != response.url.rstrip('/')]
+
+            sample_links = internal_links[:5] # The first links are prioritized language links


Why are we prioritising language links?

zaeema-n · 2026-06-30T08:09:10Z

+            if len(found_langs) == 3:
+                return TrilingualCheckResult(status="TRILINGUAL", error=None, details=", ".join(passed_criteria))
+
+            # Try deeplink crawling


Can you put the deeplink checking in a different function. This run function is quite lengthy

zaeema-n · 2026-06-30T09:17:49Z

+LANG_STORAGE_FORMATS: list[tuple[list[str], list[str]]] = [
+    (['en', 'si', 'ta'],                            ['en', 'si', 'ta']),
+    (['en-US', 'en-GB', 'si-LK', 'ta-LK', 'ta-IN'], ['en-US', 'si-LK', 'ta-LK']),
+    (['en-us', 'en-gb', 'si-lk', 'ta-lk', 'ta-in'], ['en-us', 'si-lk', 'ta-lk']),
+    (['English', 'Sinhala', 'Tamil'],               ['English', 'Sinhala', 'Tamil']),
+    (['english', 'sinhala', 'tamil'],               ['english', 'sinhala', 'tamil']),
+]


Only the first column is needed here

zaeema-n · 2026-06-30T09:26:52Z

+                            missing_injection = []
+                            langs = LANGUAGE_KEY
+
+                            for i in range(3):


Suggested change

for i in range(3):

for i in range(len(langs)):

zaeema-n · 2026-07-01T03:31:27Z

This pr closes #3

ChanukaUOJ added 3 commits June 22, 2026 16:50

trilingual check has been added to the checks with basic helpers

c31c4dc

aiohttp package removed

bea3eaf

playwrite case has been added to check the local storage

0f9bb79

gemini-code-assist Bot reviewed Jun 22, 2026

View reviewed changes

ChanukaUOJ added 9 commits June 22, 2026 19:43

security issue in playwright localstorage injection is fixed(BOT COMM…

a2ac500

…ENT)

deeplink checking has been added

24ec24b

content checking function has been changed

d1e796f

google translate language checking has been added

e0e694d

minor fix

190d18a

new extra columns added in the Check model

798d0eb

trilingual tests have been added

13c3ac7

en language check

ab53e17

minor fix and the return status type changed to block letters

e74390f

gemini-code-assist Bot reviewed Jun 25, 2026

View reviewed changes

ChanukaUOJ added 8 commits June 26, 2026 08:11

local timeout error issue fixed (bot)

fbe6341

inefficient content tags traversal fixed (bot)

7515619

chromium browser close(): resource leak issue fixed (bot)

3260f35

double www. fallback issue fixed (bot)

ee44cbb

readme file updated based on the latest changes

de98800

pytest-playwright pkg moved to dev

70ac169

function docstrings update

ace8dfa

final output csv updated

42d5285

ChanukaUOJ requested review from NethmikaKekuu and zaeema-n June 26, 2026 03:40

zaeema-n reviewed Jun 26, 2026

View reviewed changes

zaeema-n reviewed Jun 30, 2026

View reviewed changes

		if len(found_langs) == 3:
		return TrilingualCheckResult(status="TRILINGUAL", error=None, details=", ".join(passed_criteria))

		if re.search(r'(?:/si(?:[/?#]\|$)\|/ta(?:[/?#]\|$)\|[?&]lang=(?:si\|ta)(?:&\|$)\|/sinhala\|/tamil)', href_lower) or \
		any(x in text for x in ['sinhala', 'tamil', 'සිංහල', 'தமிழ்']):

Uh oh!

Conversation

ChanukaUOJ commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Detection Pipeline

Robustness & Fixes Included

Testing

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ChanukaUOJ commented Jun 25, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zaeema-n commented Jul 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ChanukaUOJ commented Jun 22, 2026 •

edited

Loading