Fix move dir in and to subdir - #81
Merged
Olof-Lagerkvist merged 1 commit intoSep 21, 2026
Merged
Olof-Lagerkvist merged 1 commit into
Olof-Lagerkvist merged 1 commit into
Conversation
Olof-Lagerkvist
merged commit Sep 21, 2026
5582753
into
LTRData:LTRData.DiscUtils-initial
3 checks passed
Member
|
Perfect! Thanks a lot for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with FatFileSystem when moving a directory from root directory to a subdirectory.
The root cause is the use of
destinationDirectoryNamewhen callingdestParent.AttachChildDirectorywhich expects name of the destination directory and not a path when it already callsAttachChildDirectoryon thedestParentinstance.Resolving the destination filename using
Utilities.GetFileFromPathand passing it todestParent.AttachChildDirectoryinstead of the destination directory name fixes the issue.2 tests have been added to verify the fix.