Create nbri_ehr module#1
Open
labkey-martyp wants to merge 1 commit into
Open
Conversation
Seeds the new nbriEHRModules repository from the nircEHRModules module tree, with every occurrence of nirc replaced by nbri (casing-matched: NIRC→NBRI, Nirc→Nbri, nirc→nbri) in file contents, file names, and directory names. Also carries over the nircEHRModules versions of the GitHub workflow files (adding permissions blocks) and .gitignore (ignoring referenceStudy ETL logs).
labkey-bpatel
left a comment
labkey-bpatel
left a comment
There was a problem hiding this comment.
Overall looks like a good starting point.
I am sure we'll trim and iterate as development progresses, but a few things stood out on this initial pass:
- Are we planning to ETL data into this module? If not, the ETL queries and definitions and go.
- Area/Building-specific .qview.xml files - there are quite a few of these with hardcoded location names (e.g. activeBehaviorCases/Building 10.qview.xml). Since these are site-specific and easy to recreate from the UI, I think we can drop them.
- Two nbri_ehr DB scripts - any reason not to combine these into a single script?
- nbri_ehr/resources/web/nbri_ehr/images/ull-logo-main-subsite.png - should be removed.
- Death/Necropsy workflow - the combined form is complex and quite center-specific. Would it be worth splitting into two separate forms (a simpler Death form and a separate Necropsy form) as a baseline?
- Copyright headers - Since this is the initial commit, normalize 'Copyright (c) 2024-2026 LabKey Corporation' (and other date-range variants) to 'Copyright (c) 2026 LabKey Corporation' across the new files.
Revised comments from claude code review:
- Remove the duplicate CagematesDemographicsProvider registration.
- Escape HL7 delimiters in the Orchard file writer.
- Null-check birth before formatting in the Orchard file writer.
- Guard isProcedureOrderEntered against empty result and null qcstate.
- Delete datasetBirth.tsv~.
- Non-blocker: Three workflows (branch_release.yml, merge_release.yml, validate_pr.yml) each add a top-level permissions: block that matches what the reusable actions require. actions/checkout@v3 is used in two of them - GitHub has been recommending v4 for a while; not blocking, but consider bumping to keep parity with the newer LabKey repos.
| private static final NBRI_EHRSchema _instance = new NBRI_EHRSchema(); | ||
| public static final String NAME = "nbri_ehr"; | ||
|
|
||
| public static NBRI_EHRSchema get_instance() |
| return ts.getRowCount(); | ||
| } | ||
|
|
||
| public boolean canCloseCase(String category) |
There was a problem hiding this comment.
param 'category' not used, should it be?
| ehrService.registerDemographicsProvider(new ProtocolAssignmentDemographicsProvider(this)); | ||
| ehrService.registerDemographicsProvider(new HousingDemographicsProvider(this)); | ||
| ehrService.registerDemographicsProvider(new CagematesDemographicsProvider(this)); | ||
| ehrService.registerDemographicsProvider(new CagematesDemographicsProvider(this)); |
There was a problem hiding this comment.
CagematesDemographicsProvider - added twice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Seeds the new nbriEHRModules repository with a working EHR module so NBRI development can proceed from a functioning baseline.
Related Pull Requests
None.
Changes