GitHub Issue 1307: Simplify container filtering in GetTransactionRowIdsAction#7841
Open
labkey-jeckels wants to merge 1 commit into
Open
GitHub Issue 1307: Simplify container filtering in GetTransactionRowIdsAction#7841labkey-jeckels wants to merge 1 commit into
labkey-jeckels wants to merge 1 commit into
Conversation
labkey-susanh
approved these changes
Jul 14, 2026
labkey-susanh
left a comment
labkey-susanh
left a comment
Contributor
There was a problem hiding this comment.
We should also remove the use of container filter from the client side.
It doesn't have to be done for 26.7, though, and I've added a TODO note for myself for the next time I've made a branch in ui-components.
| AuditLogImpl.TransactionRowIds results; | ||
| User elevatedUser = ElevatedUser.ensureCanSeeAuditLogRole(getContainer(), getUser()); | ||
| ContainerFilter cf = ContainerFilter.getContainerFilterByName(form.getContainerFilter(), getContainer(), elevatedUser); | ||
| // Issue 1307: scope strictly to the current container. 26.7 removed cross-type file imports, a transaction's rows live in the same |
Contributor
There was a problem hiding this comment.
Comment is incorrect. This should be "removed cross-folder imports". We still support cross-type imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We no longer support cross-folder imports, so no need to look beyond the current container
Related Pull Requests
Changes