Fix isnumeric() usage in SNPRC demographics queries#963
Merged
Conversation
labkey-martyp
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The related PR migrated LabKey SQL
isnumeric()from a SQL Server passthrough returningbitto a portable method returningJdbcType.BOOLEAN. On SQL Server the dialect now emits(ISNUMERIC(x) = 1), so the legacyisnumeric(x) = 1pattern in these two saved queries is generated as((ISNUMERIC(x) = 1) = 1)— invalid T-SQL, which fails the SNPRC dataset import trigger that resolvesstudy.demographicsCurLocation.Related Pull Requests
Changes
= 1fromWHEN isnumeric(...) = 1 THEN ….