Conversation
_lbug.pyd links OpenSSL dynamically (libssl-3-x64.dll, libcrypto-3-x64.dll), but delvewheel was told to exclude them, so import ladybug fails on stock Windows with 'DLL load failed' and the backend silently falls back to the C-API shim, which then raises RuntimeError (missing lbug_shared.dll). Keep OpenSSL as a DLL (never statically linked) so it can be serviced independently for security fixes, but ship the DLLs inside ladybug.libs/ like msvcp140. Everything else stays statically linked into _lbug.pyd. Linux/macOS repair commands are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows
ladybugwheels ship_lbug.pydlinked dynamically againstlibssl-3-x64.dll/libcrypto-3-x64.dll, but delvewheel was told to--excludethem. On stock Windows (no OpenSSL 3 in PATH)import ladybug._lbugfails with DLL load failed, the backend silently falls back to the C-API shim, and that raisesRuntimeError: Could not find lbug C API shared library(seen as red Windows jobs in mcp-server-ladybug CI, root cause behind LadybugDB/mcp-server-ladybug#3).Per policy OpenSSL stays a DLL (never statically linked) so it can be serviced independently for security fixes — but the DLLs are now vendored into
ladybug.libs/like msvcp140 instead of excluded. Everything else remains statically linked into_lbug.pyd(verified: the only other non-system dep in the 0.20.4 wheel is the already-vendored msvcp140). Linux/macOS repair commands are unchanged.