Repository navigation
[codex] make project advisory comments nonblocking - #239
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the project advisory comment workflow so a GitHub comment-write failure does not fail CI. The workflow is documented as advisory-only, but PRs without an existing advisory comment were failing when
gh apicould not create the sticky comment.The change also prints the underlying
ghstdout/stderr before re-raising, so future failures show the actual GitHub API error rather than only a Python traceback.Validation
uv run --group test pytest tests/test_pr_advisory.pyuv run ruff check lean_pool/pr_advisory.py tests/test_pr_advisory.pygit diff --check