Skip to content

Exposition: raise the minimal-file baseline to 214 - #284

Merged
Vilin97 merged 1 commit into
mainfrom
claude/exposition-ratchet-214
Jul 27, 2026
Merged

Vilin97 merged 1 commit into
mainfrom
claude/exposition-ratchet-214

Conversation

@Vilin97

@Vilin97 Vilin97 commented Jul 26, 2026

Copy link
Copy Markdown
Collaborator

CI measured 214/245 minimal files compiling on the merge of #283. That branch was gated at 207, which came from a local run over a smaller target set (238), so the ratchet had ~7 targets of slack — a real regression could have landed unnoticed.

Raises --baseline to the number CI actually measured. The gate's own run on this PR validates it.

🤖 Generated with Claude Code

CI measured 214/245 passing on the merge of #283 — the branch was gated at
207, the count from a local run over a smaller target set. At 207 a
six-target regression would have gone unnoticed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 26, 2026 07:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@greptile-apps

greptile-apps Bot commented Jul 26, 2026

Copy link
Copy Markdown

Greptile Summary

Raises the --baseline threshold in the exposition verification job from 207 to 214, closing a ~7-target gap between the CI-measured result on #283 (214/245) and the previously gated value (derived from a local run over a smaller target set).

  • The ratchet now reflects the actual CI-measured count so future regressions cannot slip through undetected in the gap between 207 and 214.
  • No logic or script changes — the sole diff is a single integer on the uv run python -m lean_pool.exposition.verify invocation.

Confidence Score: 5/5

Safe to merge — the only change is tightening the ratchet threshold to match what CI already measured.

The change is a single integer bump that makes the gate stricter, not looser. The new value (214) is directly sourced from the CI run on #283, so it reflects a real measurement rather than a guess. Nothing in the workflow logic, scripts, or job structure is modified.

Files Needing Attention: No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/exposition-verify.yml Single-line baseline bump from 207 to 214 in the exposition verify job, tightening the ratchet to match CI-measured results from #283.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR or weekly schedule trigger] --> B[Checkout + Restore caches]
    B --> C[Install Lean + Mathlib cache]
    C --> D[Build pool]
    D --> E[Extract declarations]
    E --> F[Generate site data]
    F --> G[Verify minimal files\n--baseline 214]
    G -->|pass: compiled >= 214/245| H[Upload report artifact]
    G -->|fail: compiled < 214| I[CI fails]
Loading

Reviews (1): Last reviewed commit: "Exposition: raise the minimal-file basel..." | Re-trigger Greptile

@Vilin97
Vilin97 merged commit ccc22df into main Jul 27, 2026
10 checks passed
@Vilin97
Vilin97 deleted the claude/exposition-ratchet-214 branch July 27, 2026 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants