Repository navigation
Treat missing lake as advisory in quality checks - #31
Merged
Merged
Conversation
The python_ci job runs without a Lean toolchain, so the two
subprocess.run calls in quality.py crash with FileNotFoundError when
the binary isn't on PATH. _check_axioms is gated by --skip-lean-axioms
but _check_project_declarations is unconditional, which is why
test_quality_check_accepts_project_card_after_imports has been red
on main since #d68ff1f.
Catch FileNotFoundError around both lake invocations and emit a
single advisory error ("... skipped: `lake` not found") instead.
Production callers still get a clear signal; the python_ci job
exercises the full static check suite without crashing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_check_project_declarations(and_check_axioms) shell out tolake env leanunconditionally. Withoutlakeon PATH,subprocess.runraisesFileNotFoundErrorand the test crashes.lakeinvocations in try/except forFileNotFoundErrorand emit a single advisory_QualityError("project declarations check skipped: `lake` not found" / "axiom audit skipped: `lake` not found") instead of crashing. Production callers still get a clear signal; the python_ci job exercises the full static check suite without aborting.subprocess.runto raiseFileNotFoundErrorand asserts the advisory message is present.lakeon PATH locally.