Repository navigation
exposition: LOC per project + main-result/dependency metrics in decls viewer - #407
Merged
Merged
Conversation
Landing page: a "Lines of Lean" tile and a LOC column on the project table (raw line count of LeanPool/<Project>.lean plus LeanPool/<Project>/**). Declarations viewer: each row now carries whether the declaration is one of the project's main results (starred, sorted first by default), its direct dependency and dependent counts, and the sizes of its transitive dependency and dependent cones within the project. Cones are computed over the SCC condensation with integer bitsets (0.3 s for the whole pool). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Advisory cross-file review against Lean Pool's supervisory rubric. This is not by itself a significance, source-verification, or merge verdict. The PR appears safe to merge with the changed exposition generation and rendering paths remaining internally consistent. Summary
Reviews (1) · Last reviewed commit: "exposition: LOC per project + main/depen..." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Landing page (
exposition/): adds a Lines of Lean stat tile and a sortable LOC column to the project table. LOC is the raw line count ofLeanPool/<Project>.leanplus everything underLeanPool/<Project>/(wc -lsemantics; the pool total matcheswc -lexactly).Declarations viewer (
exposition/decls/): each row now showsCount columns sort largest-first on first click; the two cone columns collapse on narrow screens.
Implementation
cones.py: cone sizes over the SCC condensation using Python int bitsets (Tarjan emits components dependencies-first, so one forward and one backward pass suffice). 0.3 s for all 84K declarations of the live site.decls.jsonrows extend to[name, kind, project, declId, main, deps, dependents, depCone, dependentCone];index.jsonand shardstatsgainloc. Documented inSCHEMA.md(schema 1.2, additive).Test plan
uv run --group test pytest(320 passed),ruff check,ruff format --checkindex.json/decls.jsonfrom the live site's 174 shards and served the site locally: both pages render, default sort is main-first, per-column sorts verified (largest dep cone =topological_classification_of_surfaces, 5,905; largest dependent cone = IncompletenessLO.Arrow, 6,122)🤖 Generated with Claude Code