Repository navigation
Publish documentation daily with resumable local analysis - #659
Conversation
|
Advisory cross-file review against Lean Pool's supervisory rubric. This is not by itself a significance, source-verification, or merge verdict. [High impact] The PR appears safe to merge; both previous findings are fixed and no new blocking issues were found. SummaryMoves documentation publication to a daily 06:23 UTC run, with manual dispatch.
Reviews (2) · Last reviewed commit: "Use valid private import-all syntax in t..." · Reviewed by Greptile |
|
Source review of exact head The analysis cursor covers source bytes, dependency pins and link policy. Only completed, database-validated batches advance it; failures restore the SQLite database and Lake markers together after stopping the process group. The import-all parser and failed-parent cleanup fixes are present. Analysis receipts propagate valid skips and reject failed stages or skipped rendering. Rendering requires the complete same-snapshot analysis, every local module page, matching API/exposition source markers and deployment freshness checks. I also checked removed-module handling against the pinned doc-gen implementation. The tests exercise real SQLite rollback, child-process cleanup, cursor invalidation and receipt execution. They were inspected rather than rerun; the owner's full-suite and smoke-test results remain attributed evidence. No independent full-pool documentation timing is claimed. Integration remains pending a separate policy decision. Current CONTRIBUTING.md says “Never change the checks or gates … unless explicitly asked,” explicitly including workflows and Main |
Documentation generation currently runs after content pushes and can lose hours of pool analysis at GitHub's six-hour job limit. Move publication to a daily 06:23 UTC workflow with manual dispatch, keeping the existing protected configuration/index preflight on PRs and merge groups.
The publisher pins the Lean 4.35.0-rc3-compatible interproject-linking doc-gen fork, analyzes only LeanPool modules, and links Mathlib and Tau Ceti references to their published docs. Four sequential analysis stages process modules in dependency order with 90-minute allowances, saving integrity-checked SQLite data and Lake markers between stages. A timed-out batch kills its process group and restores the last consistent database/marker pair. A source/pin/policy fingerprint prevents reuse of an obsolete progress cursor; normal Lake traces still validate module reuse.
HTML rendering has a separate job and reads all local records from the database, avoiding an import-all pool environment. Publication requires every local module page, complete same-snapshot analysis, a matching source marker and a validated exposition tree. Existing Pages stays online on failure; an incomplete cold run reports failure and resumes from its checkpoint on the next scheduled/manual run. Checkpoint cleanup uses the existing cache-maintenance workflow. The operations guide documents deployment, recovery and the fork compatibility requirement.
Validation:
import allsyntax, omission of dependency pages, warm cursor reuse and adding/removing module pages.No mathematical sources, Lean validation gates, branch protections or merge-queue requirements are changed. Full-pool publication timing remains to be measured on the first background run.