ci: revert PR #322 and fix docs deploy with github-pages environment - #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts PR #322 and applies a minimal fix instead: the docs deployment was timing out on
mainbecause thedeploy-docsjob never declared thegithub-pagesenvironment, so the Pages deployment stayed stuck indeployment_queuedand failed after 10 minutes.Changes
github-pagesenvironment (withurl: ${{ steps.deployment.outputs.page_url }}) to thedeploy-docsjob and anid: deploymenton the deploy step.actions/deploy-pagesrequires the job to target this environment; without it the deployment never resolves and times out — the root cause of the failure.Result
Docs are built once in
ci, the artifact is uploaded only on push tomain, and thedeploy-docsjob now deploys to GitHub Pages successfully instead of hanging.