Skip to content

ci: revert PR #322 and fix docs deploy with github-pages environment - #323

Merged
fsamier merged 2 commits into
mainfrom
ci/docs-upload-once
Aug 6, 2026
Merged

ci: revert PR #322 and fix docs deploy with github-pages environment#323
fsamier merged 2 commits into
mainfrom
ci/docs-upload-once

Conversation

@fsamier

@fsamier fsamier commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Summary

Reverts PR #322 and applies a minimal fix instead: the docs deployment was timing out on main because the deploy-docs job never declared the github-pages environment, so the Pages deployment stayed stuck in deployment_queued and failed after 10 minutes.

Changes

  • Revert PR ci: build and deploy docs only on push to main #322 ("Build and deploy docs only on push to main"), restoring the original build-once / upload-artifact / download-and-deploy flow.
  • Add the github-pages environment (with url: ${{ steps.deployment.outputs.page_url }}) to the deploy-docs job and an id: deployment on the deploy step. actions/deploy-pages requires the job to target this environment; without it the deployment never resolves and times out — the root cause of the failure.

Result

Docs are built once in ci, the artifact is uploaded only on push to main, and the deploy-docs job now deploys to GitHub Pages successfully instead of hanging.

@fsamier
fsamier requested a review from a team as a code owner August 6, 2026 13:35
@github-actions github-actions Bot added the ci label Aug 6, 2026
@fsamier
fsamier merged commit b514da2 into main Aug 6, 2026
10 checks passed
@fsamier
fsamier deleted the ci/docs-upload-once branch August 6, 2026 13:35
@fsamier fsamier changed the title Revert PR #322 and fix docs deploy with github-pages environment ci: revert PR #322 and fix docs deploy with github-pages environment Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant