fix(kernels): don't fail all2all build on CUDA 12.8 deprecation warnings - #264
Open
blue (Blueyyds) wants to merge 1 commit into
Open
fix(kernels): don't fail all2all build on CUDA 12.8 deprecation warnings#264blue (Blueyyds) wants to merge 1 commit into
blue (Blueyyds) wants to merge 1 commit into
Conversation
CUDA 12.8's cuSPARSE headers declare legacy API types as deprecated, and PyTorch pulls those declarations in transitively. With -Werror in effect the third-party deprecation turned into a hard build failure for the all2all_cpp extension on our CUDA 12.8 hosts. Add -Wno-deprecated-declarations so the strict warning policy still applies to this extension's own sources without being hostage to third-party headers. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CUDA 12.8's cuSPARSE headers declare legacy API types as deprecated, and PyTorch pulls those declarations in transitively. With -Werror in effect the third-party deprecation turned into a hard build failure for the all2all_cpp extension on our CUDA 12.8 hosts.
Add -Wno-deprecated-declarations so the strict warning policy still applies to this extension's own sources without being hostage to third-party headers.