feat: Add POIDraft for Apex Legends - #7808
Conversation
Rathoz
changed the title
ElectricalBoy
left a comment
ElectricalBoy
left a comment
There was a problem hiding this comment.
all widget2 impls should be converted to widget3 before merge
There was a problem hiding this comment.
putting this under the Widget/ directory feels wrong
There was a problem hiding this comment.
Will try to check the widget3 thing. If I understand correctly then data I should move just to apexlegends/POIDraft/POIMAP/Data.lua ?
There was a problem hiding this comment.
sounds better than putting it under Widget/ directory
There was a problem hiding this comment.
why not use the structure from the rfc already?
fwiw personally i think for features that are completely wiki specific we should drop the custom. but the rest should still be applicable
There was a problem hiding this comment.
@hjpalpha.
uff. So you mean that it should look something like this?
I guess I could try that. Is there any example which already use this structure?
lua/wikis/apexlegends/POIDraft/
├── POIDraft.lua
├── Data.lua
├── Lib/
│ └── Util.lua
└── Components/
├── POIMap.lua
├── POILabel.lua
└── Table.luaThere was a problem hiding this comment.
lua/wikis/apexlegends/Features/POIDraft/
├── Controller.lua <-- entry points & calls the other stuff to combine it
└── Components/ <-- only display here, no logics
├── Map.lua
├── Label.lua
└── Table.lua
├── Lib/ <-- logics go in here (if suitable split it into Map/Label/Table here instead of 1 Util)
│ └── Util.lua
├── Types.lua <-- basically your current `Data.lua` plus the class (anno) definitions of the other files of this PRThis file contains the data structure for various maps and points of interest (POIs) in the game Apex Legends, including their coordinates, mobile names, and date boundaries.
Refactor POIMap to use Helpers for filtering and rendering.
Refactor PoiDraft to use Helpers for row rendering and convert to functional component.
Added type annotations for PoiMapComponent methods.
3 participants
Summary
This module was for some time already live in Apex. I just tried to update it to table2 and now moving to GH
Module usage can be viewed here
https://liquipedia.net/apexlegends/Apex_Legends_Global_Series/2026/Split_1/Playoffs/POI_Drafts
Mobile:
How did you test this change?
live