refactor(match2): remove date param in createGame (and fix some annotations) - #7968
Merged
Conversation
hjpalpha
approved these changes
Aug 16, 2026
Rathoz
force-pushed
the
m2-ms-remove-param
branch
from
August 24, 2026 11:25
698a047 to
2f28384
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the match-summary callback API to derive dates from each game and broadens return annotations to Renderable.
Changes:
- Removes the obsolete
dateparameter fromcreateGame. - Updates base dispatch and affected annotations.
- Uses
game.datewhere game dates are displayed.
Reviewed changes
Copilot reviewed 44 out of 44 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lua/wikis/zula/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/worldofwarcraft/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/worldoftanks/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/wildrift/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/warthunder/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/trackmania/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/thefinals/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/tft/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/tetris/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/teamfortress/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/tarkovarena/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/squadrons/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/splitgate/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/splatoon/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/smite/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/sideswipe/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/runeterra/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/rocketleague/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/rematch/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/pubgmobile/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/pubg/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/pokemon/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/paladins/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/marvelrivals/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/magic/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/halo/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/goals/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/geoguessr/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/freefire/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/fortnite/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/eva/MatchSummary.Lua | Updated as part of this pull request. |
| lua/wikis/deltaforce/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/crossfire/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/criticalops/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/commons/MatchSummary/Base.lua | Updated as part of this pull request. |
| lua/wikis/clashroyale/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/clashofclans/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/callofduty/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/battlerite/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/battalion/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/autochess/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/artifact/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/arenafps/MatchSummary.lua | Updated as part of this pull request. |
| lua/wikis/apexlegends/MatchSummary.lua | Updated as part of this pull request. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hjpalpha
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This parameter (match date) is no longer needed as game.date is set and populated these days.
How did you test this change?
dev