Skip to content

refactor(match2): remove date param in createGame (and fix some annotations) - #7968

Merged
Rathoz merged 2 commits into
mainfrom
m2-ms-remove-param
Aug 24, 2026
Merged

refactor(match2): remove date param in createGame (and fix some annotations)#7968
Rathoz merged 2 commits into
mainfrom
m2-ms-remove-param

Conversation

@Rathoz

@Rathoz Rathoz commented Aug 16, 2026

Copy link
Copy Markdown
Member

Summary

This parameter (match date) is no longer needed as game.date is set and populated these days.

How did you test this change?

dev

@Rathoz Rathoz changed the title refactor: remove date param in createGame (and fix some annotations) refactor(match2): remove date param in createGame (and fix some annotations) Aug 17, 2026
@Rathoz
Rathoz force-pushed the m2-ms-remove-param branch from 698a047 to 2f28384 Compare August 24, 2026 11:25
@Rathoz
Rathoz requested a review from hjpalpha August 24, 2026 11:30
@Rathoz
Rathoz marked this pull request as ready for review August 24, 2026 11:30
@Rathoz
Rathoz requested review from a team as code owners August 24, 2026 11:30
Copilot AI lite review requested due to automatic review settings August 24, 2026 11:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the match-summary callback API to derive dates from each game and broadens return annotations to Renderable.

Changes:

  • Removes the obsolete date parameter from createGame.
  • Updates base dispatch and affected annotations.
  • Uses game.date where game dates are displayed.

Reviewed changes

Copilot reviewed 44 out of 44 changed files in this pull request and generated no comments.

Show a summary per file
File Description
lua/wikis/zula/MatchSummary.lua Updated as part of this pull request.
lua/wikis/worldofwarcraft/MatchSummary.lua Updated as part of this pull request.
lua/wikis/worldoftanks/MatchSummary.lua Updated as part of this pull request.
lua/wikis/wildrift/MatchSummary.lua Updated as part of this pull request.
lua/wikis/warthunder/MatchSummary.lua Updated as part of this pull request.
lua/wikis/trackmania/MatchSummary.lua Updated as part of this pull request.
lua/wikis/thefinals/MatchSummary.lua Updated as part of this pull request.
lua/wikis/tft/MatchSummary.lua Updated as part of this pull request.
lua/wikis/tetris/MatchSummary.lua Updated as part of this pull request.
lua/wikis/teamfortress/MatchSummary.lua Updated as part of this pull request.
lua/wikis/tarkovarena/MatchSummary.lua Updated as part of this pull request.
lua/wikis/squadrons/MatchSummary.lua Updated as part of this pull request.
lua/wikis/splitgate/MatchSummary.lua Updated as part of this pull request.
lua/wikis/splatoon/MatchSummary.lua Updated as part of this pull request.
lua/wikis/smite/MatchSummary.lua Updated as part of this pull request.
lua/wikis/sideswipe/MatchSummary.lua Updated as part of this pull request.
lua/wikis/runeterra/MatchSummary.lua Updated as part of this pull request.
lua/wikis/rocketleague/MatchSummary.lua Updated as part of this pull request.
lua/wikis/rematch/MatchSummary.lua Updated as part of this pull request.
lua/wikis/pubgmobile/MatchSummary.lua Updated as part of this pull request.
lua/wikis/pubg/MatchSummary.lua Updated as part of this pull request.
lua/wikis/pokemon/MatchSummary.lua Updated as part of this pull request.
lua/wikis/paladins/MatchSummary.lua Updated as part of this pull request.
lua/wikis/marvelrivals/MatchSummary.lua Updated as part of this pull request.
lua/wikis/magic/MatchSummary.lua Updated as part of this pull request.
lua/wikis/halo/MatchSummary.lua Updated as part of this pull request.
lua/wikis/goals/MatchSummary.lua Updated as part of this pull request.
lua/wikis/geoguessr/MatchSummary.lua Updated as part of this pull request.
lua/wikis/freefire/MatchSummary.lua Updated as part of this pull request.
lua/wikis/fortnite/MatchSummary.lua Updated as part of this pull request.
lua/wikis/eva/MatchSummary.Lua Updated as part of this pull request.
lua/wikis/deltaforce/MatchSummary.lua Updated as part of this pull request.
lua/wikis/crossfire/MatchSummary.lua Updated as part of this pull request.
lua/wikis/criticalops/MatchSummary.lua Updated as part of this pull request.
lua/wikis/commons/MatchSummary/Base.lua Updated as part of this pull request.
lua/wikis/clashroyale/MatchSummary.lua Updated as part of this pull request.
lua/wikis/clashofclans/MatchSummary.lua Updated as part of this pull request.
lua/wikis/callofduty/MatchSummary.lua Updated as part of this pull request.
lua/wikis/battlerite/MatchSummary.lua Updated as part of this pull request.
lua/wikis/battalion/MatchSummary.lua Updated as part of this pull request.
lua/wikis/autochess/MatchSummary.lua Updated as part of this pull request.
lua/wikis/artifact/MatchSummary.lua Updated as part of this pull request.
lua/wikis/arenafps/MatchSummary.lua Updated as part of this pull request.
lua/wikis/apexlegends/MatchSummary.lua Updated as part of this pull request.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@Rathoz
Rathoz merged commit 3cfe8e8 into main Aug 24, 2026
9 checks passed
@Rathoz
Rathoz deleted the m2-ms-remove-param branch August 24, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants