refactor(match2): allow passing the GameRow only - #7976
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the shared MatchSummary base implementation to support customizing game rendering by providing a GameRow component directly (instead of requiring createGames / createGame), and updates the Chess wiki implementation to use that new hook.
Changes:
- Extend
CustomMatchSummaryInterfaceand default body rendering to supportCustomMatchSummary.GameRow. - Refactor the default body builder to render games via
GameRowwhen present (falling back tocreateGames/createGame). - Update
lua/wikis/chess/MatchSummary.luato provideGameRowand remove its customcreateGamesimplementation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lua/wikis/commons/MatchSummary/Base.lua | Adds GameRow support and routes default game rendering through it when available. |
| lua/wikis/chess/MatchSummary.lua | Switches Chess match summary customization to provide GameRow instead of createGames. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hjpalpha
reviewed
Aug 18, 2026
hjpalpha
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow setup to pass only GameRow Widget in Custom Match Summary. Set it up on chess as well.
How did you test this change?
tested together with the 4th PR in the stack