feat: macOS support#276
Merged
Merged
Conversation
ReenigneArcher
left a comment
Member
There was a problem hiding this comment.
This is awesome, thank you! I didn't test any of this, but the code structure seems generally good and follows the existing patterns in the project.
Could you fix the reported sonar issues and duplication? I normally point the AI to a sonar mcp server to do this, but that may not work if you don't own the project in sonar. I think it will work if you give it the link directly (https://sonarcloud.io/project/issues?id=LizardByte_libdisplaydevice&pullRequest=276&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)... if it's too much trouble, I could also take care of that.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
…lay ID as capture selector
205398c to
9274aba
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
As requested, here's the macOS support PR, and a windows+macoOS power-management subfeature aimed at keeping the display awake.
Does not work:
So in summary, it's useful from day one when it gets integrated into Sunshine (conform to capture resolution, refresh rate, etc) with cross-platform semantics. It is not a 1:1 feature-complete Windows-equivalent implementation because macOS public display APIs do not expose the same topology, inactive-display, and HDR controls.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
AI was heavily used, especially for tests; all code has been reviewed before committing.