feat: add bounded semantic hover - #210
Merged
Merged
Conversation
yashranaway
requested changes
Sep 22, 2026
yashranaway
left a comment
yashranaway
left a comment
Collaborator
There was a problem hiding this comment.
Thermo-nuclear + deslop: defer.
Per prior flag and PR body, edge + refresh behavior for hover still undefined. If hover reveals auth/forms but refresh invalidates refs without revalidation (like #212 does), we risk stale revealed surface. Also flow recording exclusion needs explicit decision.
Blockers before merge:
- Refresh / stale / hidden / obscured revalidation for hover
- Obscured-target check before dispatch (dropdowns often obscured)
- Document why hover never records in flow vs screenshot series
Code otherwise clean, protocol +2 minimal, no rewrite needed. Re-approve once 1-3 clarified.
Share one post-scroll hit test for the synthetic and CDP paths, reject a covered target before any pointer event, and pause recording when a hover handler navigates. Record why hover is not replayed in a flow.
yashranaway
force-pushed
the
feat/35-semantic-hover
branch
from
September 22, 2026 18:57
34c706a to
c64c2ff
Compare
The hover target checks and the region screenshot checks overflowed one function once both landed. Split them into helpers.
yashranaway
approved these changes
Sep 22, 2026
yashranaway
left a comment
yashranaway
left a comment
Collaborator
There was a problem hiding this comment.
Hover now resolves a ref from the latest inspection, rejects a hidden, detached, or covered target before any pointer event, and stays out of flow replay. Recording pauses when a hover handler navigates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hoveras a semantic CLI, wire protocol, MCP, and SDK command using ref or role/name targetsAUTH_REQUIREDchallenge flowSecurity
Testing
pnpm testpnpm test:runtimepnpm test:npmpnpm buildpnpm test:e2e:linuxCloses #35