Skip to content

Add delay functionality for laser pulse actions - #2

Open
XuanMabard wants to merge 1 commit into
mainfrom
Fsgui-ifdelay
Open

Add delay functionality for laser pulse actions#2
XuanMabard wants to merge 1 commit into
mainfrom
Fsgui-ifdelay

Conversation

@XuanMabard

Copy link
Copy Markdown
Collaborator

Adds ifdelay support across action and source modules, including delayed laser pulse handling, plus local config and notebook/backup variants used during development.

Adds ifdelay support across action and source modules, including
delayed laser pulse handling, plus local config and notebook/backup
variants used during development.
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@XuanMabard
XuanMabard requested a review from shijiegu August 31, 2026 20:35
@shijiegu

shijiegu commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Code generally makes sense but why are there so many __init__ variants in fsgui.spikegadgets.action? They are not reachable, or are they? They look like intermediates for testing. If they are, consider adding a testing folder that includes python scripts to call these generator functions and include generated Statescripts; in the test include some string grep to see if needed parameters are properly written in generated Statescripts. If all the variants are needed, consider a refactor (consider kwargs and syntax using **params) and please avoid code duplication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants