Wait for the lab review sheet to stop sliding before measuring - #1091
Merged
Merged
Conversation
…ring On a phone and a small tablet the review sheet slides up from the bottom; its width settles before the slide ends, so waiting on width alone still compared fields from different frames. The spec now waits for every running animation to finish and for the surface to hold its position and width across two frames.
…s row The spec compared field tops within 8 px. A field label that wraps onto a second line, which depends on the runner's font metrics, moves that field's input down by one line while it stays in the same row, and the 560 px case failed on it. A field is now beside the value when it sits to its right and starts above the value's bottom edge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1088, which did not cure the flake: the 560 px and 390 px cases of the lab-scan review spec still failed on the first attempt (#1087, #1086). On a phone and a small tablet the review sheet slides up from the bottom; its width settles before the slide ends, so the width-only wait passed at once and the spec still compared field positions from different frames. It now awaits every running animation (
document.getAnimations()) and then requires the surface's width and y position to hold across two frames. No product change.