Skip to content

COMMON.md: run the engine's presence.ps1 -Fleet, now that the engine copy has it (vault BACKLOG #3674) - #229

Merged
wshallwshall merged 3 commits into
mainfrom
fleet-flag-engine-copy
Oct 17, 2026
Merged

wshallwshall merged 3 commits into
mainfrom
fleet-flag-engine-copy

Conversation

@wshallwshall

Copy link
Copy Markdown
Collaborator

Vault BACKLOG #3674, closing step 4. Engine PR MEFORORG/MessageFoundry#2355 (merged as 45f0346d4) gave the engine's scripts/coord/presence.ps1 a -Fleet switch. So readers no longer run korus's copy by path for it. This changes only roles/COMMON.md (+20/-6).

Changes

  • "The exceptions" row: drops the presence.ps1 -Fleet entry, since the engine copy now takes -Fleet.
  • The repo-axis table row for presence.ps1 -Fleet now reads true. It scans your repo and every repo the records name, on every account. It cannot see another machine, nor at least the cwd shapes listed below.
  • The 2026-09-19 measurement now says it measured korus's copy.
  • The by-path instruction from korus PR 228 is replaced with an instruction to run the engine's copy from an engine worktree current with origin/main. The source was read at engine origin/main 064700f2d on 2026-10-17. The new text:
    • Warns readers off korus's own copy, which scans the caller's repo only as a fallback.
    • Keeps the caveat: a -Fleet roster without a seat does not prove the seat absent.
    • Adds a three-row table of sessions no form of the roster can place: a cwd outside git, a gone cwd with no checkout above it, and another machine.
    • Says the engine copy exits 0 even when the roster is incomplete, so a reader checks the Roster UNAVAILABLE/INCOMPLETE line or the -Json receipt, not the exit code.
  • The Builder narrowed the brief's caveat to match the engine source. A gone-checkout record makes the fence UNAVAILABLE only for the caller's own repo, and only in the two occupancy.ps1 shapes. Another repo named only by a gone cwd is not scanned.

The wiki note coord/presence/fleet-flag is corrected separately, by event 20261017T144420738Z-zp60qd. It corrects 20261012T152837537Z-l477qc.

Checks

  • test_prose_rules_hold, test_role_cards, test_the_seat_that_opens_a_pr_is_stated_once and test_presence_states_its_scope: 107 passed, 1 failed. The failure is test_the_default_run_prints_the_scope_warning. It fails the same way on origin/main 6b9df03, and it runs korus's script, not COMMON.md.
  • The added lines are plain ASCII. merge-tree --write-tree origin/main origin/fleet-flag-engine-copy exits 0.

QA

QA -- korus roles/BUILDER.md step 11, head 570cd841dd2a5ca2c62e0dac51d2afbbc88172a1
Level: high. Tag: none returned.
Rounds: 1. Findings: 7 confirmed and fixed, 1 rejected (the stale wiki citation, which the wiki correction fixes outside the diff), 2 open.

Open:

  1. Korus's own scripts/coord/presence.ps1 still ships the weaker -Fleet, and its default-run warning points at itself. COMMON.md now warns readers off it. Changing or retiring the script is a new row.
  2. The fixes in 570cd84 were not re-reviewed.

The engine copy exits 0 on an incomplete roster, while korus's exits 2. That is deliberate: the engine's existing tests assert exit 0, and the PR 2355 brief kept it. COMMON.md now says to read the line, not the exit code. So it is not a finding.

Ledger banner (proposed)

#3674 step 4 done: korus COMMON.md points -Fleet at the engine copy and the wiki note is corrected; all four closing steps are met.

…KLOG #3674, step 4)

Engine PR 2355 gave the engine's scripts/coord/presence.ps1 a -Fleet
switch. The exceptions row drops the korus by-path entry, the by-path
instruction from korus PR 228 now names the engine copy, and the caveat
describes the engine behaviour: it always scans the caller's repository,
and a -Fleet roster still cannot list sessions whose cwd is outside git,
gone with no checkout above it, or on another machine.

Proposed PR title: COMMON.md runs the engine's presence.ps1 -Fleet (vault #3674 step 4)
Proposed ledger banner: #3674 step 4 built (korus COMMON.md and wiki note);
findings 4 to 6 of the pass F note remain.
…CKLOG #3674, step 4)

The instruction requires an engine worktree current with origin/main,
cites the PR 2355 merge commit, warns off the korus copy, qualifies
the always-scanned claim, and says the engine copy exits 0 when the
roster is incomplete. The 2026-09-19 measurement names the korus copy.
…p 4)

The command names the engine worktree explicitly, the fence shapes hold
for every scanned repository, the exit-0 note covers the not-in-git
path, and the wiki line says the vault page still names the korus route.
@wshallwshall

Copy link
Copy Markdown
Collaborator Author

Lander: merging at pinned head 54fa1f3. The Lander's xhigh review covered the whole diff at 570cd84, including the round-1 fixes. The fix commit 54fa1f3 applies that review's four fixes; the Lander checked its diff, which adds two paragraph splits for the prose ratchets. Required gates are green. Follow-ups are filed in vault (#3752, via vault PR 2500).

@wshallwshall
wshallwshall merged commit 65d11f7 into main Oct 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant