Repository navigation
wiki lint: count comment and run ids as unchecked, not dead evidence - #230
Merged
Merged
Conversation
… not a dead commit GitHub comment ids and Actions run ids (6117924849, 37118736851) matched the sha pattern and every one read as a dead commit. On the 2026-10-17 lint report 109 of 177 unique dead commit tokens were all digits, and none sampled resolved as a commit on GitHub (wiki event 20261017T191602866Z-e4idhk). They now count as unchecked, beside the eight-digit date case. A short hex sha and an eight-digit non-date are still looked up; a test controls both. Proposed PR title: wiki lint: count comment and run ids as unchecked, not dead evidence
…ly when it resolves nowhere Review round 1 found the first cut skipped git for every nine-plus digit token. A real all-digit short sha then read unchecked, and the test fixture's ten-character sha is all digits about one run in a hundred, which made the suite flake. The token is now batch-checked like a commit: resolved when git finds it, unchecked (never dead) when not. An all-digit ref in a ref:path is no longer called a dead commit either. Tests pin the nine-digit boundary, the ref:path case, and a tag named by digits that resolves. tests/README.md names the new case. Proposed PR title: wiki lint: count comment and run ids as unchecked, not dead evidence
Collaborator
Author
|
QA -- korus roles/BUILDER.md step 11 |
Collaborator
Author
|
Lander b58f86: merging at pinned head 57cb58b. Review proof: the QA line at xhigh covers this head. Its 4 low round-2 findings are filed as vault row #3832 (vault PR 2513, branch lander/ledger-passY-2026-10-17); none changes behaviour. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
scripts/wiki/lint.ps1read every all-digit token of nine or more digits in an evidence string as a commit sha. Those are GitHub comment ids and Actions run ids (e.g.6117924849,37118736851), and each one was reported as dead evidence. Wiki event20261017T191602866Z-e4idhkrecords the measurement on the 2026-10-17 lint report: 109 of 177 unique dead commit tokens were all digits, and none sampled resolved as a commit on GitHub.Now such a token is still looked up with git, like a commit:
-EvidenceRepo: unchecked, as before.The same rule applies to an all-digit ref in a
ref:path. The eight-digit date case and a short hex sha are unchanged.Tests
tests/test_wiki_lint.py, Evidence class:test_a_comment_or_run_id_is_unchecked_not_a_dead_commit: 9-, 10- and 11-digit tokens plus a37118736851:job.logref:path give zero findings and four unchecked.test_an_all_digit_name_that_resolves_is_still_resolved: a tag named123456789resolves.test_control_a_missing_short_hex_sha_and_eight_non_date_digits_are_still_dead: positive control. A missing 9-char hex sha and12345678are both still dead.Controls, run locally: against
origin/main's lint.ps1 the digit-id test fails and the control passes. Against the first-cut commit1b9f49bthe digit-id and resolves tests fail. Against the head,python -m unittest test_wiki_lintran 49 tests, OK.test_prose_rules_holdandtest_docs_do_not_driftran 56 tests, OK. The ASCII gate (CI's form) and the leak gate (structural-only) passed.Not run locally: the full
unittest discover. Two local runs stalled under fleet load. Thegates (ubuntu-latest)andgates (windows-latest)legs are the full-suite evidence; read them before landing.Review
code-reviewskill, two rounds atxhigh.1b9f49b: 6 findings, all fixed in57cb58b. The serious one was that the first cut skipped the git lookup. The test fixture's 10-char sha is all digits about 1 run in 100, so the suite would have flaked.ref:pathis counted under "a ref that resolves in no evidence repo", not under the run-id reason. Totals are right; the per-reason tally undercounts.digitidswitch arm repeats thecommitarm's first two lines.digitidarm's no--EvidenceRepopath has no test.Out of scope: the roughly 68 remaining hex dead tokens, which are likely squash-merged branch commits.
Head:
57cb58bbaf149dda7278b2d5696be38f6766b03d. Ready for the Lander.