Pair each GraceDB server with its Kafka broker - #542
Merged
Merged
Conversation
deepchatterjeeligo
left a comment
deepchatterjeeligo
left a comment
Contributor
There was a problem hiding this comment.
Wondering if we should also make the http fallback configurable instead of hardcoding to True.
Contributor
Author
|
Oh, true. Given that LLAI will potentially want it turned off entirely, I'll have it default to |
deepchatterjeeligo
approved these changes
Oct 2, 2026
deepchatterjeeligo
left a comment
deepchatterjeeligo
left a comment
Contributor
There was a problem hiding this comment.
Thanks @wbenoit26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@deepchatterjeeligo This PR explicitly links each GraceDB server to the appropriate broker (and also drops
test01as an option, as that doesn't seem to be valid anymore). This doesn't strictly need to make it into a release, as we can specify the broker from the config file. But might be good to do anyway. There are a couple monitoring bug fixes I want to make as well.