IR1 bug fixes - #543
Merged
Merged
IR1 bug fixes#543
Conversation
deepchatterjeeligo
approved these changes
Oct 2, 2026
deepchatterjeeligo
left a comment
Contributor
There was a problem hiding this comment.
Had a look. All changes make sense to me. Happy to give this a shot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@deepchatterjeeligo Fixes a few bugs I encountered while running over the LLPIC. None of these are strictly necessary, but are nice to have. All of the commits are self-contained, so we can cherry-pick a subset if desired.
LD_LIBRARY_PATHset inapptainer.defdoesn't get transferred over, which can break imports. The search happens to make it through, but the monitor fails without the environment variable set.segments.txtbut thecurrent.jsonheartbeat file didn't get removed. When the search restarted, the flush of the oldcurrent.jsoncaused the final segment to get duplicated. I've added a check before a segment gets appended for whether the current segment has the same state and start time as the previous one, and also a function to checksegments.txtfor overlapping segments and write a warning to the summary page if any exist.