Skip to content

IR1 bug fixes - #543

Merged
wbenoit26 merged 4 commits into
ML4GW:mainfrom
wbenoit26:ir1-bug-fixes
Oct 3, 2026
Merged

wbenoit26 merged 4 commits into
ML4GW:mainfrom
wbenoit26:ir1-bug-fixes

Conversation

@wbenoit26

Copy link
Copy Markdown
Contributor

@deepchatterjeeligo Fixes a few bugs I encountered while running over the LLPIC. None of these are strictly necessary, but are nice to have. All of the commits are self-contained, so we can cherry-pick a subset if desired.

  • The binning in the latency histogram caused the fastest and slowest events to be excluded from the plot. I've added a bit of padding to the bin range.
  • When the CI builds the docker image, the LD_LIBRARY_PATH set in apptainer.def doesn't get transferred over, which can break imports. The search happens to make it through, but the monitor fails without the environment variable set.
  • I noticed that our latency measurement includes the GraceDB response time. I've added another timestamp to record the time it takes to get a response back, so the histogram just shows latency coming from our end.
  • When the node rebooted last time, the process got shut down in a way such that the final segment got written to segments.txt but the current.json heartbeat file didn't get removed. When the search restarted, the flush of the old current.json caused the final segment to get duplicated. I've added a check before a segment gets appended for whether the current segment has the same state and start time as the previous one, and also a function to check segments.txt for overlapping segments and write a warning to the summary page if any exist.

@deepchatterjeeligo deepchatterjeeligo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a look. All changes make sense to me. Happy to give this a shot

@wbenoit26
wbenoit26 merged commit c46b69a into ML4GW:main Oct 3, 2026
5 checks passed
@wbenoit26
wbenoit26 deleted the ir1-bug-fixes branch October 3, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants